Add Arma CI Workflow (validate, lint, build) (#7207)

* No sqflint failures for now due to false-positives
* Upload artifact of armake build
* Cleanup Circle CI configuration
* Add BOM check
* Cleanup BOM

.github/workflows/arma.yml

@@ -0,0 +1,45 @@
+name: Arma
+
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+
+jobs:
+  validate:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout the source code
+      uses: actions/checkout@master
+    - name: Validate SQF
+      run: python3 tools/sqf_validator.py
+    - name: Validate Config
+      run: python3 tools/config_style_checker.py
+    - name: Validate String Tables
+      run: python3 tools/check_strings.py
+    - name: Check for BOM
+      uses: arma-actions/bom-check@master
+
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout the source code
+      uses: actions/checkout@master
+    - name: Lint (sqflint)
+      uses: arma-actions/sqflint@master
+      continue-on-error: true # No failure due to many false-positives
+
+  build:
+    runs-on: ubuntu-latest
+    container: acemod/armake:master
+    steps:
+    - name: Checkout the source code
+      uses: actions/checkout@master
+    - name: Build (armake)
+      run: armake --version && make -j4
+    - name: Upload Artifact
+      uses: actions/upload-artifact@master
+      with:
+        name: ace3-${{ github.sha }}-nobin
+        path: '@ace'

circle.yml

@@ -1,36 +1,5 @@
 version: 2
 jobs:
-  validate-scripts:
-    docker:
-      - image: acemod/sqflint:latest
-    steps:
-      - checkout
-      - run:
-          name: Validate SQF and Config style and Stringtable entries
-          command: python tools/sqf_validator.py && python tools/config_style_checker.py && python tools/check_strings.py
-
-  linting:
-    docker:
-      - image: acemod/sqflint:latest
-    steps:
-      - checkout
-      - run:
-          name: Lint sqf code
-          command: sqflint -d addons || true
-
-  armake:
-    docker:
-      - image: acemod/armake:master
-    steps:
-      - checkout
-      - run:
-          name: Version
-          command: armake --version
-      - run:
-          name: Build
-          command: |
-            make -j 4
-
   update-docs:
     docker:
       - image: acemod/armake:latest
@@ -49,14 +18,7 @@ workflows:
   version: 2
   build-job:
     jobs:
-      - linting
-      - validate-scripts
-      - armake:
-          requires:
-            - validate-scripts
       - update-docs:
-          requires:
-            - armake
           filters:
             branches:
               only: master

docs/wiki/feature/dragon.md

@@ -1,4 +1,4 @@
----
+---
 layout: wiki
 title: M47 Dragon Missile
 description: M47 Dragon

tools/search_privates.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python3
+#!/usr/bin/env python3
 
 import fnmatch
 import os

tools/search_undefinedFunctions.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python3
+#!/usr/bin/env python3
 
 import fnmatch
 import os

tools/search_unused_privates.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python3
+#!/usr/bin/env python3
 
 import fnmatch
 import os

tools/sqf_linter.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python3
+#!/usr/bin/env python3
 
 # Requires: https://github.com/LordGolias/sqf