Arma3_Epoch/ACE3
1
0
Fork 0
mirror of https://github.com/acemod/ACE3.git synced 2024-08-30 18:23:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Coding Guidelines inconsistencies (#8481)

Browse Source
This commit is contained in:
Whigital 2021-10-05 19:20:52 +02:00 committed by GitHub
parent cb07e2ceba
commit 6b05da7632
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
docs/wiki/development/coding-guidelines.md
View File

@ -463,17 +463,17 @@ Good:
```js
if (call FUNC(myCondition)) then {
private _areAllAboveTen = true; // <- smallest feasable scope
private _areAllAboveTen = true; // <- smallest feasable scope
{
if (_x >= 10) then {
_areAllAboveTen = false;
};
} forEach _anArray;
{
if (_x >= 10) then {
_areAllAboveTen = false;
};
} forEach _anArray;
if (_areAllAboveTen) then {
hint "all values are above ten!";
};
if (_areAllAboveTen) then {
hint "all values are above ten!";
};
}
```
@ -482,15 +482,15 @@ Bad:
```js
private _areAllAboveTen = true; // <- this is bad, because it can be initialized in the if statement
if (call FUNC(myCondition)) then {
{
if (_x >= 10) then {
_areAllAboveTen = false;
};
} forEach _anArray;
{
if (_x >= 10) then {
_areAllAboveTen = false;
};
} forEach _anArray;
if (_areAllAboveTen) then {
hint "all values are above ten!";
};
if (_areAllAboveTen) then {
hint "all values are above ten!";
};
};
```
@ -575,8 +575,8 @@ Good:
```js
fnc_example = {
params ["_content"];
hint _content;
params ["_content"];
hint _content;
};
```
@ -719,7 +719,7 @@ _a pushBack _value;
Also good:
```js
_a append [1,2,3];
_a append [1, 2, 3];
```
Bad: