From 94cf661e448e316cbd2dc977d43e52bfacdd1a4a Mon Sep 17 00:00:00 2001 From: Glowbal Date: Sat, 28 Nov 2015 19:40:59 +0100 Subject: [PATCH] Add mention when make fails to build all pbos. - Prints all failed modules when make has completed - No longer prints green OK text if a single module fails - Gives a count of how many modules have failed to build This is done to prevent overlooking of a failed pbo in the build process, since there is a huge amount of modules being build. --- tools/make.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/make.py b/tools/make.py index e4b99116a6..82c7a881d6 100644 --- a/tools/make.py +++ b/tools/make.py @@ -1083,6 +1083,9 @@ See the make.cfg file for additional build options. print_error("\nFailed to delete {}".format(os.path.join(obsolete_check_path,file))) pass + amountOfBuildsFailed = 0 + namesOfBuildsFailed = [] + # For each module, prep files and then build. print_blue("\nBuilding...") for module in modules: @@ -1222,6 +1225,8 @@ See the make.cfg file for additional build options. print_error("pboProject return code == {}".format(str(ret))) print_error("Module not successfully built/signed. Check your {}temp\{}_packing.log for more info.".format(work_drive,module)) print ("Resuming build...") + amountOfBuildsFailed += 1 + namesOfBuildsFailed.append("{}".format(module)) continue # Back to the root @@ -1388,8 +1393,14 @@ See the make.cfg file for additional build options. except: print_error("Could not copy files. Is Arma 3 running?") - print_green("\nDone.") + if amountOfBuildsFailed > 0: + print_error("Build failed. {} pbos failed.".format(amountOfBuildsFailed)) + for failedModuleName in namesOfBuildsFailed: + print("- {} failed.".format(failedModuleName)) + + else: + print_green("\Completed with 0 errors.") if __name__ == "__main__": start_time = timeit.default_timer()