From 1202289fab6ae465f5f6dadc75f2d3ebd423785e Mon Sep 17 00:00:00 2001 From: Mikayla Fischler Date: Mon, 17 Jul 2023 20:59:45 -0400 Subject: [PATCH 1/3] #285 #286 mitigated false trips --- supervisor/startup.lua | 2 +- supervisor/unitlogic.lua | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/supervisor/startup.lua b/supervisor/startup.lua index e9e82c9..123ba21 100644 --- a/supervisor/startup.lua +++ b/supervisor/startup.lua @@ -21,7 +21,7 @@ local supervisor = require("supervisor.supervisor") local svsessions = require("supervisor.session.svsessions") -local SUPERVISOR_VERSION = "v0.20.2" +local SUPERVISOR_VERSION = "v0.20.3" local println = util.println local println_ts = util.println_ts diff --git a/supervisor/unitlogic.lua b/supervisor/unitlogic.lua index fab67f3..dbf4255 100644 --- a/supervisor/unitlogic.lua +++ b/supervisor/unitlogic.lua @@ -329,11 +329,12 @@ function logic.update_annunciator(self) Generator Trip a generator trip is when a generator suddenly and unexpectedly loses it's external load oftentimes this is when a power plant is disconnected from the grid for one reason or another - in this case we just: + in this case we: - check if internal power storage of turbine is increasing + - check that there is at least 5% energy fill, preventing false trips with periodic power extraction that means there is no external load and there will be a turbine trip soon if this is not resolved ]]-- - self.db.annunciator.GeneratorTrip[idx] = _get_dt(DT_KEYS.TurbinePower .. idx) > 0.0 + self.db.annunciator.GeneratorTrip[idx] = (_get_dt(DT_KEYS.TurbinePower .. idx) > 0.0) and (db.tanks.energy_fill > 0.05) --[[ Turbine Trip @@ -504,9 +505,6 @@ function logic.update_alarms(self) local rcs_trans = any_low or any_over or gen_trip or annunc.RCPTrip or annunc.MaxWaterReturnFeed - -- only care about RCS flow low early with boilers - if self.num_boilers > 0 then rcs_trans = rcs_trans or annunc.RCSFlowLow end - -- annunciator indicators for these states may not indicate a real issue when: -- > flow is ramping up right after reactor start -- > flow is ramping down after reactor shutdown From 455653074a9251ae10896c5b97d9043e9bbeb970 Mon Sep 17 00:00:00 2001 From: Mikayla Fischler Date: Mon, 17 Jul 2023 22:09:21 -0400 Subject: [PATCH 2/3] #287 fixed coordinator not notifying supervisor of auto waste config --- coordinator/process.lua | 4 ++++ coordinator/startup.lua | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/coordinator/process.lua b/coordinator/process.lua index ad9c94f..5551c93 100644 --- a/coordinator/process.lua +++ b/coordinator/process.lua @@ -75,6 +75,10 @@ function process.init(iocontrol, coord_comms) end log.info("PROCESS: loaded auto control settings from coord.settings") + + -- notify supervisor of auto waste config + self.comms.send_fac_command(FAC_COMMAND.SET_WASTE_MODE, self.config.waste_product) + self.comms.send_fac_command(FAC_COMMAND.SET_PU_FB, self.config.pu_fallback) end -- unit waste states diff --git a/coordinator/startup.lua b/coordinator/startup.lua index 0a922b7..9294633 100644 --- a/coordinator/startup.lua +++ b/coordinator/startup.lua @@ -22,7 +22,7 @@ local sounder = require("coordinator.sounder") local apisessions = require("coordinator.session.apisessions") -local COORDINATOR_VERSION = "v0.21.0" +local COORDINATOR_VERSION = "v0.21.1" local println = util.println local println_ts = util.println_ts From c0f45cfb8b7c22ada558730140f567714bdf504f Mon Sep 17 00:00:00 2001 From: Mikayla Fischler Date: Mon, 17 Jul 2023 22:47:19 -0400 Subject: [PATCH 3/3] updated comments --- supervisor/unitlogic.lua | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/supervisor/unitlogic.lua b/supervisor/unitlogic.lua index dbf4255..6003ac8 100644 --- a/supervisor/unitlogic.lua +++ b/supervisor/unitlogic.lua @@ -327,12 +327,12 @@ function logic.update_annunciator(self) --[[ Generator Trip - a generator trip is when a generator suddenly and unexpectedly loses it's external load - oftentimes this is when a power plant is disconnected from the grid for one reason or another - in this case we: - - check if internal power storage of turbine is increasing - - check that there is at least 5% energy fill, preventing false trips with periodic power extraction - that means there is no external load and there will be a turbine trip soon if this is not resolved + a generator trip is when a generator suddenly and unexpectedly loses it's external load, which occurs when a power plant + is disconnected from the grid. in our case, this is when the turbine is disconnected, or what it's connected to becomes + fully charged. this is identified by detecting if: + - the internal power storage of the turbine is increasing AND + - there is at least 5% energy fill (preventing false trips with periodic power extraction from other mods) + this would then mean there is no external load and there will be a turbine trip soon if this is not resolved ]]-- self.db.annunciator.GeneratorTrip[idx] = (_get_dt(DT_KEYS.TurbinePower .. idx) > 0.0) and (db.tanks.energy_fill > 0.05)