#406 bounds check all controls

graphics/core.lua

@@ -7,7 +7,7 @@ local flasher = require("graphics.flasher")
 
 local core = {}
 
-core.version = "2.2.0"
+core.version = "2.2.1"
 
 core.flasher = flasher
 core.events = events

graphics/elements/controls/hazard_button.lua

@@ -138,23 +138,21 @@ local function hazard_button(args)
     -- handle mouse interaction
     ---@param event mouse_interaction mouse event
     function e.handle_mouse(event)
-        if e.enabled then
+        if e.enabled and core.events.was_clicked(event.type) and e.in_frame_bounds(event.current.x, event.current.y) then
-            if core.events.was_clicked(event.type) then
+            -- change text color to indicate clicked
-                -- change text color to indicate clicked
+            e.w_set_fgd(args.accent)
-                e.w_set_fgd(args.accent)
+            e.w_set_cur(3, 2)
-                e.w_set_cur(3, 2)
+            e.w_write(args.text)
-                e.w_write(args.text)
 
-                -- abort any other callbacks
+            -- abort any other callbacks
-                tcd.abort(on_timeout)
+            tcd.abort(on_timeout)
-                tcd.abort(on_success)
+            tcd.abort(on_success)
-                tcd.abort(on_failure)
+            tcd.abort(on_failure)
 
-                -- 1.5 second timeout
+            -- 1.5 second timeout
-                tcd.dispatch(1.5, on_timeout)
+            tcd.dispatch(1.5, on_timeout)
 
-                args.callback()
+            args.callback()
-            end
         end
     end
 

graphics/elements/controls/radio_button.lua

@@ -90,7 +90,8 @@ local function radio_button(args)
     -- handle mouse interaction
     ---@param event mouse_interaction mouse event
     function e.handle_mouse(event)
-        if e.enabled and core.events.was_clicked(event.type) and (event.initial.y == event.current.y) then
+        if e.enabled and core.events.was_clicked(event.type) and
+           (event.initial.y == event.current.y) and e.in_frame_bounds(event.current.x, event.current.y) then
             -- determine what was pressed
             if args.options[event.current.y] ~= nil then
                 e.value = event.current.y

graphics/elements/controls/spinbox_numeric.lua

@@ -127,20 +127,19 @@ local function spinbox(args)
     ---@param event mouse_interaction mouse event
     function e.handle_mouse(event)
         -- only handle if on an increment or decrement arrow
-        if e.enabled and core.events.was_clicked(event.type) and
+        if e.enabled and core.events.was_clicked(event.type) and e.in_frame_bounds(event.current.x, event.current.y) and
-                (event.current.x ~= dec_point_x) and (event.current.y ~= 2) then
+           (event.current.x ~= dec_point_x) and (event.current.y ~= 2) and
-            if event.current.x == event.initial.x and event.current.y == event.initial.y then
+           (event.current.x == event.initial.x) and (event.current.y == event.initial.y) then
-                local idx = util.trinary(event.current.x > dec_point_x, event.current.x - 1, event.current.x)
+            local idx = util.trinary(event.current.x > dec_point_x, event.current.x - 1, event.current.x)
-                if digits[idx] ~= nil then
+            if digits[idx] ~= nil then
-                    if event.current.y == 1 then
+                if event.current.y == 1 then
-                        digits[idx] = digits[idx] + 1
+                    digits[idx] = digits[idx] + 1
-                    elseif event.current.y == 3 then
+                elseif event.current.y == 3 then
-                        digits[idx] = digits[idx] - 1
+                    digits[idx] = digits[idx] - 1
-                    end
-
-                    update_value()
-                    show_num()
                 end
+
+                update_value()
+                show_num()
             end
         end
     end

graphics/elements/controls/switch_button.lua

@@ -58,7 +58,7 @@ local function switch_button(args)
     -- handle mouse interaction
     ---@param event mouse_interaction mouse event
     function e.handle_mouse(event)
-        if e.enabled and core.events.was_clicked(event.type) then
+        if e.enabled and core.events.was_clicked(event.type) and e.in_frame_bounds(event.current.x, event.current.y) then
             e.value = not e.value
             e.redraw()
             args.callback(e.value)

graphics/elements/controls/tabbar.lua

@@ -98,7 +98,7 @@ local function tabbar(args)
     ---@param event mouse_interaction mouse event
     function e.handle_mouse(event)
         -- determine what was pressed
-        if e.enabled and core.events.was_clicked(event.type) then
+        if e.enabled and core.events.was_clicked(event.type) and e.in_frame_bounds(event.current.x, event.current.y) then
             -- a button may have been pressed, which one was it?
             local tab_ini = which_tab(event.initial.x)
             local tab_cur = which_tab(event.current.x)

graphics/elements/form/number_field.lua

@@ -53,11 +53,11 @@ local function number_field(args)
     ---@param event mouse_interaction mouse event
     function e.handle_mouse(event)
         -- only handle if on an increment or decrement arrow
-        if e.enabled then
+        if e.enabled and e.in_frame_bounds(event.current.x, event.current.y) then
             if core.events.was_clicked(event.type) then
                 e.take_focus()
 
-                if event.type == MOUSE_CLICK.UP and e.in_frame_bounds(event.current.x, event.current.y) then
+                if event.type == MOUSE_CLICK.UP then
                     ifield.move_cursor(event.current.x)
                 end
             elseif event.type == MOUSE_CLICK.DOUBLE_CLICK then

graphics/elements/form/text_field.lua

@@ -41,11 +41,11 @@ local function text_field(args)
     ---@param event mouse_interaction mouse event
     function e.handle_mouse(event)
         -- only handle if on an increment or decrement arrow
-        if e.enabled then
+        if e.enabled and e.in_frame_bounds(event.current.x, event.current.y) then
             if core.events.was_clicked(event.type) then
                 e.take_focus()
 
-                if event.type == MOUSE_CLICK.UP and e.in_frame_bounds(event.current.x, event.current.y) then
+                if event.type == MOUSE_CLICK.UP then
                     ifield.move_cursor(event.current.x)
                 end
             elseif event.type == MOUSE_CLICK.DOUBLE_CLICK then