Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: only show collapse all subpages button when then page is expanded

Browse Source
This commit is contained in:
Lucas.Xu 2024-07-27 22:53:22 +08:00
parent 2a3c915fe4
commit 15dd92afb3
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart
View File

@ -1,5 +1,3 @@
import 'package:flutter/material.dart';
import 'package:appflowy/generated/locale_keys.g.dart'; import 'package:appflowy/generated/locale_keys.g.dart';
import 'package:appflowy/startup/startup.dart'; import 'package:appflowy/startup/startup.dart';
import 'package:appflowy/workspace/application/favorite/favorite_bloc.dart'; import 'package:appflowy/workspace/application/favorite/favorite_bloc.dart';
@ -14,6 +12,7 @@ import 'package:appflowy_backend/protobuf/flowy-folder/view.pb.dart';
import 'package:appflowy_popover/appflowy_popover.dart'; import 'package:appflowy_popover/appflowy_popover.dart';
import 'package:easy_localization/easy_localization.dart'; import 'package:easy_localization/easy_localization.dart';
import 'package:flowy_infra_ui/widget/flowy_tooltip.dart'; import 'package:flowy_infra_ui/widget/flowy_tooltip.dart';
import 'package:flutter/material.dart';
import 'package:flutter_bloc/flutter_bloc.dart'; import 'package:flutter_bloc/flutter_bloc.dart';
class FavoriteMoreActions extends StatelessWidget { class FavoriteMoreActions extends StatelessWidget {
@ -28,6 +27,7 @@ class FavoriteMoreActions extends StatelessWidget {
child: ViewMoreActionButton( child: ViewMoreActionButton(
view: view, view: view,
spaceType: FolderSpaceType.favorite, spaceType: FolderSpaceType.favorite,
isExpanded: false,
onEditing: (value) => onEditing: (value) =>
context.read<ViewBloc>().add(ViewEvent.setIsEditing(value)), context.read<ViewBloc>().add(ViewEvent.setIsEditing(value)),
onAction: (action, _) { onAction: (action, _) {

1
frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart
View File

@ -693,6 +693,7 @@ class _SingleInnerViewItemState extends State<SingleInnerViewItem> {
message: LocaleKeys.menuAppHeader_moreButtonToolTip.tr(), message: LocaleKeys.menuAppHeader_moreButtonToolTip.tr(),
child: ViewMoreActionButton( child: ViewMoreActionButton(
view: widget.view, view: widget.view,
isExpanded: widget.isExpanded,
spaceType: widget.spaceType, spaceType: widget.spaceType,
onEditing: (value) => onEditing: (value) =>
context.read<ViewBloc>().add(ViewEvent.setIsEditing(value)), context.read<ViewBloc>().add(ViewEvent.setIsEditing(value)),

6
frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart
View File

@ -19,12 +19,14 @@ class ViewMoreActionButton extends StatelessWidget {
required this.onEditing, required this.onEditing,
required this.onAction, required this.onAction,
required this.spaceType, required this.spaceType,
required this.isExpanded,
}); });
final ViewPB view; final ViewPB view;
final void Function(bool value) onEditing; final void Function(bool value) onEditing;
final void Function(ViewMoreActionType type, dynamic data) onAction; final void Function(ViewMoreActionType type, dynamic data) onAction;
final FolderSpaceType spaceType; final FolderSpaceType spaceType;
final bool isExpanded;
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
@ -102,7 +104,9 @@ class ViewMoreActionButton extends StatelessWidget {
// Chat doesn't change collapse // Chat doesn't change collapse
// Only show collapse all pages if the view has child views // Only show collapse all pages if the view has child views
if (view.layout != ViewLayoutPB.Chat && view.childViews.isNotEmpty) { if (view.layout != ViewLayoutPB.Chat &&
view.childViews.isNotEmpty &&
isExpanded) {
actionTypes.add(ViewMoreActionType.collapseAllPages); actionTypes.add(ViewMoreActionType.collapseAllPages);
actionTypes.add(ViewMoreActionType.divider); actionTypes.add(ViewMoreActionType.divider);
} }