Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: more board fixes (#3821)

Browse Source 
* fix: null check value

* refactor: remove unnecessary blocbuilder

* fix: missing checkbox icon at top of board column
This commit is contained in:
Richard Shiue 2023-10-29 12:51:34 +08:00 committed by GitHub
parent b9a25f449f
commit 18bd91936c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 68 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart
View File

@ -235,12 +235,14 @@ class BoardBloc extends Bloc<BoardEvent, BoardState> {
if (isClosed || !layoutSettings.hasBoard()) { if (isClosed || !layoutSettings.hasBoard()) {
return; return;
} }
if (ungroupedGroup != null) {
if (layoutSettings.board.hideUngroupedColumn) { if (layoutSettings.board.hideUngroupedColumn) {
boardController.removeGroup(ungroupedGroup!.fieldId); boardController.removeGroup(ungroupedGroup!.fieldId);
} else if (ungroupedGroup != null) { } else {
final newGroup = initializeGroupData(ungroupedGroup!); final newGroup = initializeGroupData(ungroupedGroup!);
boardController.addGroup(newGroup); boardController.addGroup(newGroup);
} }
}
add(BoardEvent.didUpdateLayoutSettings(layoutSettings.board)); add(BoardEvent.didUpdateLayoutSettings(layoutSettings.board));
}, },
); );

7
frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/widgets/board_column_header.dart
View File

@ -62,9 +62,7 @@ class _BoardColumnHeaderState extends State<BoardColumnHeader> {
Widget build(BuildContext context) { Widget build(BuildContext context) {
final boardCustomData = widget.groupData.customData as GroupData; final boardCustomData = widget.groupData.customData as GroupData;
return BlocProvider<BoardBloc>.value( return BlocBuilder<BoardBloc, BoardState>(
value: context.read<BoardBloc>(),
child: BlocBuilder<BoardBloc, BoardState>(
builder: (context, state) { builder: (context, state) {
if (state.isEditingHeader) { if (state.isEditingHeader) {
WidgetsBinding.instance.addPostFrameCallback((_) { WidgetsBinding.instance.addPostFrameCallback((_) {
@ -132,7 +130,6 @@ class _BoardColumnHeaderState extends State<BoardColumnHeader> {
margin: widget.margin ?? EdgeInsets.zero, margin: widget.margin ?? EdgeInsets.zero,
); );
}, },
),
); );
} }
@ -224,5 +221,5 @@ Widget? _buildHeaderIcon(GroupData customData) {
); );
} }
return null; return widget;
} }