Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: binary search selection supports searching child nodes

Browse Source
This commit is contained in:
Lucas.Xu 2022-08-08 18:11:20 +08:00
parent 2f84d7e54e
commit 1ece5cfd9e
3 changed files with 26 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/app_flowy/packages/flowy_editor/lib/document/node_iterator.dart
View File

@ -43,7 +43,7 @@ class NodeIterator implements Iterator<Node> {
if (nextOfParent == null) { if (nextOfParent == null) {
_currentNode = null; _currentNode = null;
} else { } else {
_currentNode = _findLeadingChild(node); _currentNode = _findLeadingChild(nextOfParent);
} }
} }

16
frontend/app_flowy/packages/flowy_editor/lib/render/rich_text/checkbox_text.dart
View File

@ -110,11 +110,17 @@ class _CheckboxNodeWidgetState extends State<CheckboxNodeWidget>
.map( .map(
(child) => widget.editorState.service.renderPluginService (child) => widget.editorState.service.renderPluginService
.buildPluginWidget( .buildPluginWidget(
NodeWidgetContext( child is TextNode
context: context, ? NodeWidgetContext<TextNode>(
node: child, context: context,
editorState: widget.editorState, node: child,
), editorState: widget.editorState,
)
: NodeWidgetContext<Node>(
context: context,
node: child,
editorState: widget.editorState,
),
), ),
) )
.toList(), .toList(),

16
frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart
View File

@ -527,6 +527,7 @@ class _FlowySelectionState extends State<FlowySelection>
/// currently only single-level nesting is supported /// currently only single-level nesting is supported
// find the first node's rect.bottom <= offset.dy // find the first node's rect.bottom <= offset.dy
Node _lowerBound(List<Node> sortedNodes, Offset offset, int start, int end) { Node _lowerBound(List<Node> sortedNodes, Offset offset, int start, int end) {
assert(start >= 0 && end < sortedNodes.length);
var min = start; var min = start;
var max = end; var max = end;
while (min <= max) { while (min <= max) {
@ -537,7 +538,12 @@ class _FlowySelectionState extends State<FlowySelection>
max = mid - 1; max = mid - 1;
} }
} }
return sortedNodes[min]; final node = sortedNodes[min];
if (node.children.isNotEmpty && node.children.first.rect.top <= offset.dy) {
final children = node.children.toList(growable: false);
return _lowerBound(children, offset, 0, children.length - 1);
}
return node;
} }
/// TODO: Supports multi-level nesting, /// TODO: Supports multi-level nesting,
@ -549,6 +555,7 @@ class _FlowySelectionState extends State<FlowySelection>
int start, int start,
int end, int end,
) { ) {
assert(start >= 0 && end < sortedNodes.length);
var min = start; var min = start;
var max = end; var max = end;
while (min <= max) { while (min <= max) {
@ -559,7 +566,12 @@ class _FlowySelectionState extends State<FlowySelection>
max = mid - 1; max = mid - 1;
} }
} }
return sortedNodes[max]; final node = sortedNodes[max];
if (node.children.isNotEmpty && node.children.first.rect.top <= offset.dy) {
final children = node.children.toList(growable: false);
return _lowerBound(children, offset, 0, children.length - 1);
}
return node;
} }
} }