Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: add remove out of bound guard

Browse Source
This commit is contained in:
appflowy
2022-08-26 08:32:25 +08:00
parent 96fcedf771
commit 2b725f8f71
3 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/app_flowy/lib/plugins/board/presentation/card/board_select_option_cell.dart
View File

@ -37,6 +37,9 @@ class _BoardSelectOptionCellState extends State<BoardSelectOptionCell> {
return BlocProvider.value( return BlocProvider.value(
value: _cellBloc, value: _cellBloc,
child: BlocBuilder<BoardSelectOptionCellBloc, BoardSelectOptionCellState>( child: BlocBuilder<BoardSelectOptionCellBloc, BoardSelectOptionCellState>(
// buildWhen: (previous, current) {
// return previous.selectedOptions != current.selectedOptions;
// },
builder: (context, state) { builder: (context, state) {
if (state.selectedOptions if (state.selectedOptions
.where((element) => element.id == widget.groupId) .where((element) => element.id == widget.groupId)

4
frontend/app_flowy/packages/appflowy_board/lib/src/widgets/board_column/board_column_data.dart
View File

@ -121,6 +121,10 @@ class AFBoardColumnDataController extends ChangeNotifier with EquatableMixin {
columnData._items.add(newItem); columnData._items.add(newItem);
Log.debug('[$AFBoardColumnDataController] $columnData add $newItem'); Log.debug('[$AFBoardColumnDataController] $columnData add $newItem');
} else { } else {
if (index >= columnData._items.length) {
return;
}
final removedItem = columnData._items.removeAt(index); final removedItem = columnData._items.removeAt(index);
columnData._items.insert(index, newItem); columnData._items.insert(index, newItem);
Log.debug( Log.debug(

2
frontend/app_flowy/packages/appflowy_board/lib/src/widgets/reorder_flex/drag_target.dart
View File

@ -140,7 +140,7 @@ class _ReorderDragTargetState<T extends DragTargetData>
widget.insertAnimationController, widget.insertAnimationController,
widget.deleteAnimationController, widget.deleteAnimationController,
) ?? ) ??
LongPressDraggable<DragTargetData>( Draggable<DragTargetData>(
maxSimultaneousDrags: 1, maxSimultaneousDrags: 1,
data: widget.dragTargetData, data: widget.dragTargetData,
ignoringFeedbackSemantics: false, ignoringFeedbackSemantics: false,