Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: expand inline menu width (#5867)

Browse Source
This commit is contained in:
Lucas.Xu 2024-08-02 22:00:28 +08:00 committed by GitHub
parent 46bad4e7e8
commit 393850ae4b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 23 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart
View File

@ -51,9 +51,10 @@ class MobileHomePageHeader extends StatelessWidget {
),
child: const Padding(
padding: EdgeInsets.all(8.0),
child: FlowySvg(FlowySvgs.m_setting_m),
child: FlowySvg(FlowySvgs.m_notification_settings_s),
),
),
const HSpace(8.0),
],
),
);

12
frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart
View File

@ -1,7 +1,6 @@
import 'dart:async';
import 'package:appflowy/generated/locale_keys.g.dart';
import 'package:appflowy/plugins/base/emoji/emoji_text.dart';
import 'package:appflowy/plugins/document/presentation/editor_plugins/base/insert_page_command.dart';
import 'package:appflowy/plugins/document/presentation/editor_plugins/mention/mention_block.dart';
import 'package:appflowy/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart';
@ -17,6 +16,7 @@ import 'package:appflowy_backend/protobuf/flowy-error/errors.pb.dart';
import 'package:appflowy_backend/protobuf/flowy-folder/view.pb.dart';
import 'package:appflowy_editor/appflowy_editor.dart';
import 'package:easy_localization/easy_localization.dart';
import 'package:flowy_infra_ui/flowy_infra_ui.dart';
import 'package:flowy_infra_ui/widget/dialog/styled_dialogs.dart';
import 'package:flowy_infra_ui/widget/error_page.dart';
import 'package:flutter/material.dart';
@ -228,11 +228,11 @@ class InlinePageReferenceService extends InlineActionsDelegate {
keywords: [view.name.toLowerCase()],
label: view.name,
icon: (onSelected) => view.icon.value.isNotEmpty
? EmojiText(
emoji: view.icon.value,
fontSize: 12,
textAlign: TextAlign.center,
lineHeight: 1.3,
? FlowyText.emoji(
view.icon.value,
fontSize: 14,
figmaLineHeight: 18.0,
// optimizeEmojiAlign: true,
)
: view.defaultIcon(),
onSelected: (context, editorState, menu, replace) => insertPage

13
frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_handler.dart
View File

@ -1,8 +1,5 @@
import 'dart:async';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:appflowy/generated/locale_keys.g.dart';
import 'package:appflowy/plugins/inline_actions/inline_actions_menu.dart';
import 'package:appflowy/plugins/inline_actions/inline_actions_result.dart';
@ -12,13 +9,16 @@ import 'package:appflowy_editor/appflowy_editor.dart';
import 'package:collection/collection.dart';
import 'package:easy_localization/easy_localization.dart';
import 'package:flowy_infra_ui/style_widget/text.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
/// All heights are in physical pixels
const double _groupTextHeight = 14; // 12 height + 2 bottom spacing
const double _groupBottomSpacing = 6;
const double _itemHeight = 30; // 26 height + 4 vertical spacing (2*2)
const double _menuHeight = 300;
const double kInlineMenuHeight = 300;
const double kInlineMenuWidth = 400;
const double _contentHeight = 260;
extension _StartWithsSort on List<InlineActionsResult> {
@ -152,7 +152,10 @@ class _InlineActionsHandlerState extends State<InlineActionsHandler> {
focusNode: _focusNode,
onKeyEvent: onKeyEvent,
child: Container(
constraints: BoxConstraints.loose(const Size(200, _menuHeight)),
constraints: const BoxConstraints(
maxHeight: kInlineMenuHeight,
minWidth: kInlineMenuWidth,
),
decoration: BoxDecoration(
color: widget.style.backgroundColor,
borderRadius: BorderRadius.circular(6.0),

9
frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart
View File

@ -1,5 +1,6 @@
import 'package:appflowy/plugins/inline_actions/inline_actions_menu.dart';
import 'package:appflowy/plugins/inline_actions/inline_actions_result.dart';
import 'package:appflowy/plugins/inline_actions/widgets/inline_actions_handler.dart';
import 'package:appflowy_editor/appflowy_editor.dart';
import 'package:collection/collection.dart';
import 'package:flowy_infra_ui/style_widget/button.dart';
@ -92,11 +93,15 @@ class _InlineActionsWidgetState extends State<InlineActionsWidget> {
return Padding(
padding: const EdgeInsets.symmetric(vertical: 2),
child: SizedBox(
width: 200,
width: kInlineMenuWidth,
child: FlowyButton(
expand: true,
isSelected: widget.isSelected,
leftIcon: widget.item.icon?.call(widget.isSelected),
text: FlowyText.regular(widget.item.label),
text: FlowyText.regular(
widget.item.label,
figmaLineHeight: 18,
),
onTap: _onPressed,
),
),