Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: extract edit and reset btns as widgets

Browse Source
This commit is contained in:
MayurSMahajan 2024-08-24 16:11:02 +05:30
parent cbc735ae14
commit 3cd5fe44c8
1 changed files with 63 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

98
frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart
View File

@ -413,8 +413,8 @@ class _ShortcutSettingTileState extends State<ShortcutSettingTile> {
if (isHovering) if (isHovering)
Row( Row(
children: [ children: [
GestureDetector( EditShortcutBtn(
onTap: () { onEdit: () {
if (widget.canStartEditing()) { if (widget.canStartEditing()) {
setState(() { setState(() {
widget.onStartEditing(); widget.onStartEditing();
@ -422,41 +422,11 @@ class _ShortcutSettingTileState extends State<ShortcutSettingTile> {
}); });
} }
}, },
child: MouseRegion(
cursor: SystemMouseCursors.click,
child: FlowyTooltip(
message: LocaleKeys.settings_shortcutsPage_editTooltip.tr(),
child: const FlowySvg(
FlowySvgs.edit_s,
size: Size.square(16),
),
),
),
), ),
const HSpace(16), const HSpace(16),
Opacity( ResetShortcutBtn(
opacity: canReset ? 1 : 0.5, onReset: () => _resetIndividualCommand(widget.command),
child: GestureDetector( canReset: canReset,
onTap: canReset
? () => _resetIndividualCommand(widget.command)
: null,
child: MouseRegion(
cursor:
canReset ? SystemMouseCursors.click : MouseCursor.defer,
child: FlowyTooltip(
message: canReset
? LocaleKeys.settings_shortcutsPage_resetSingleTooltip
.tr()
: LocaleKeys
.settings_shortcutsPage_unavailableResetSingleTooltip
.tr(),
child: const FlowySvg(
FlowySvgs.restore_s,
size: Size.square(16),
),
),
),
),
), ),
], ],
), ),
@ -507,6 +477,64 @@ class _ShortcutSettingTileState extends State<ShortcutSettingTile> {
} }
} }
class EditShortcutBtn extends StatelessWidget {
const EditShortcutBtn({super.key, required this.onEdit});
final VoidCallback onEdit;
@override
Widget build(BuildContext context) {
return GestureDetector(
onTap: onEdit,
child: MouseRegion(
cursor: SystemMouseCursors.click,
child: FlowyTooltip(
message: LocaleKeys.settings_shortcutsPage_editTooltip.tr(),
child: const FlowySvg(
FlowySvgs.edit_s,
size: Size.square(16),
),
),
),
);
}
}
class ResetShortcutBtn extends StatelessWidget {
const ResetShortcutBtn({
super.key,
required this.onReset,
required this.canReset,
});
final bool canReset;
final VoidCallback onReset;
@override
Widget build(BuildContext context) {
return Opacity(
opacity: canReset ? 1 : 0.5,
child: GestureDetector(
onTap: canReset ? onReset : null,
child: MouseRegion(
cursor: canReset ? SystemMouseCursors.click : MouseCursor.defer,
child: FlowyTooltip(
message: canReset
? LocaleKeys.settings_shortcutsPage_resetSingleTooltip.tr()
: LocaleKeys
.settings_shortcutsPage_unavailableResetSingleTooltip
.tr(),
child: const FlowySvg(
FlowySvgs.restore_s,
size: Size.square(16),
),
),
),
),
);
}
}
@visibleForTesting @visibleForTesting
class KeyBadge extends StatelessWidget { class KeyBadge extends StatelessWidget {
const KeyBadge({super.key, required this.keyLabel}); const KeyBadge({super.key, required this.keyLabel});