Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: debounce causes save cell data fail

Browse Source
This commit is contained in:
appflowy 2022-08-18 15:38:55 +08:00
parent 4856a024a2
commit 3e4e8679ce
4 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart
View File

@ -111,7 +111,7 @@ class SelectOptionCellEditorBloc
void _loadOptions() { void _loadOptions() {
_delayOperation?.cancel(); _delayOperation?.cancel();
_delayOperation = Timer(const Duration(milliseconds: 10), () { _delayOperation = Timer(const Duration(milliseconds: 10), () {
_selectOptionService.getOpitonContext().then((result) { _selectOptionService.getOptionContext().then((result) {
if (isClosed) { if (isClosed) {
return; return;
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/select_option_service.dart
View File

@ -55,7 +55,7 @@ class SelectOptionService {
return GridEventUpdateSelectOption(payload).send(); return GridEventUpdateSelectOption(payload).send();
} }
Future<Either<SelectOptionCellDataPB, FlowyError>> getOpitonContext() { Future<Either<SelectOptionCellDataPB, FlowyError>> getOptionContext() {
final payload = GridCellIdPB.create() final payload = GridCellIdPB.create()
..gridId = gridId ..gridId = gridId
..fieldId = fieldId ..fieldId = fieldId

9
frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/number_cell.dart
View File

@ -65,6 +65,8 @@ class _NumberCellState extends GridFocusNodeCellState<GridNumberCell> {
@override @override
Future<void> dispose() async { Future<void> dispose() async {
_delayOperation = null;
_cellBloc.close();
super.dispose(); super.dispose();
} }
@ -72,15 +74,10 @@ class _NumberCellState extends GridFocusNodeCellState<GridNumberCell> {
Future<void> focusChanged() async { Future<void> focusChanged() async {
if (mounted) { if (mounted) {
_delayOperation?.cancel(); _delayOperation?.cancel();
_delayOperation = Timer(const Duration(milliseconds: 300), () { _delayOperation = Timer(const Duration(milliseconds: 30), () {
if (_cellBloc.isClosed == false && if (_cellBloc.isClosed == false &&
_controller.text != contentFromState(_cellBloc.state)) { _controller.text != contentFromState(_cellBloc.state)) {
_cellBloc.add(NumberCellEvent.updateCell(_controller.text)); _cellBloc.add(NumberCellEvent.updateCell(_controller.text));
if (!mounted) {
_delayOperation = null;
_cellBloc.close();
}
} }
}); });
} }

4
frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/text_cell.dart
View File

@ -76,7 +76,7 @@ class _GridTextCellState extends GridFocusNodeCellState<GridTextCell> {
@override @override
Future<void> dispose() async { Future<void> dispose() async {
_delayOperation?.cancel(); _delayOperation = null;
_cellBloc.close(); _cellBloc.close();
super.dispose(); super.dispose();
} }
@ -85,7 +85,7 @@ class _GridTextCellState extends GridFocusNodeCellState<GridTextCell> {
Future<void> focusChanged() async { Future<void> focusChanged() async {
if (mounted) { if (mounted) {
_delayOperation?.cancel(); _delayOperation?.cancel();
_delayOperation = Timer(const Duration(milliseconds: 300), () { _delayOperation = Timer(const Duration(milliseconds: 30), () {
if (_cellBloc.isClosed == false && if (_cellBloc.isClosed == false &&
_controller.text != _cellBloc.state.content) { _controller.text != _cellBloc.state.content) {
_cellBloc.add(TextCellEvent.updateText(_controller.text)); _cellBloc.add(TextCellEvent.updateText(_controller.text));