From 3ee703cd6d5813e08b49b290935eca1fa37586d2 Mon Sep 17 00:00:00 2001 From: Alexandre Moreau Date: Tue, 18 Oct 2022 19:03:26 +0200 Subject: [PATCH] style: align code and add comment --- .../presentation/widgets/header/field_cell.dart | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart index 59160565c9..0ee7462e22 100755 --- a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart +++ b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart @@ -161,18 +161,23 @@ class FieldCellButton extends StatelessWidget { @override Widget build(BuildContext context) { final theme = context.watch(); + + // Using this technique to have proper text ellipsis + // https://github.com/flutter/flutter/issues/18761#issuecomment-812390920 + final text = Characters(field.name) + .replaceAll(Characters(''), Characters('\u{200B}')) + .toString(); return FlowyButton( radius: BorderRadius.zero, hoverColor: theme.shader6, onTap: onTap, leftIcon: svgWidget(field.fieldType.iconName(), color: theme.iconColor), text: FlowyText.medium( - Characters(field.name) - .replaceAll(Characters(''), Characters('\u{200B}')) - .toString(), - fontSize: 12, - maxLines: maxLines, - overflow: TextOverflow.ellipsis), + text, + fontSize: 12, + maxLines: maxLines, + overflow: TextOverflow.ellipsis, + ), margin: GridSize.cellContentInsets, ); }