Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: padding for edit field (#1400)

Browse Source
This commit is contained in:
Nathan.fooo 2022-10-30 19:31:53 +08:00 committed by GitHub
parent fa4e3d0d2a
commit 3fbcd928db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 30 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart
View File

@ -53,20 +53,23 @@ class _SelectOptionCellEditorState extends State<SelectOptionCellEditor> {
)..add(const SelectOptionEditorEvent.initial()),
child: BlocBuilder<SelectOptionCellEditorBloc, SelectOptionEditorState>(
builder: (context, state) {
return CustomScrollView(
shrinkWrap: true,
slivers: [
SliverToBoxAdapter(
child: _TextField(popoverMutex: popoverMutex),
),
const SliverToBoxAdapter(child: VSpace(6)),
const SliverToBoxAdapter(child: TypeOptionSeparator()),
const SliverToBoxAdapter(child: VSpace(6)),
const SliverToBoxAdapter(child: _Title()),
SliverToBoxAdapter(
child: _OptionList(popoverMutex: popoverMutex),
),
],
return Padding(
padding: const EdgeInsets.all(6.0),
child: CustomScrollView(
shrinkWrap: true,
slivers: [
SliverToBoxAdapter(
child: _TextField(popoverMutex: popoverMutex),
),
const SliverToBoxAdapter(child: VSpace(6)),
const SliverToBoxAdapter(child: TypeOptionSeparator()),
const SliverToBoxAdapter(child: VSpace(6)),
const SliverToBoxAdapter(child: _Title()),
SliverToBoxAdapter(
child: _OptionList(popoverMutex: popoverMutex),
),
],
),
);
},
),

1
frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart
View File

@ -168,7 +168,6 @@ class FieldCellButton extends StatelessWidget {
.replaceAll(Characters(''), Characters('\u{200B}'))
.toString();
return FlowyButton(
radius: BorderRadius.zero,
hoverColor: theme.shader6,
onTap: onTap,
leftIcon: svgWidget(field.fieldType.iconName(), color: theme.iconColor),

11
frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart
View File

@ -63,10 +63,13 @@ class SelectOptionTypeOptionEditor extends StatelessWidget {
return SizedBox(
width: 160,
child: CustomScrollView(
slivers: slivers,
controller: ScrollController(),
physics: StyledScrollPhysics(),
child: Padding(
padding: const EdgeInsets.all(6.0),
child: CustomScrollView(
slivers: slivers,
controller: ScrollController(),
physics: StyledScrollPhysics(),
),
),
);
},

11
frontend/app_flowy/lib/plugins/grid/presentation/widgets/row/row_detail.dart
View File

@ -59,7 +59,7 @@ class _RowDetailPageState extends State<RowDetailPage> {
child: Column(
children: [
SizedBox(
height: 40,
height: 30,
child: Row(
children: const [Spacer(), _CloseButton()],
),
@ -264,15 +264,14 @@ class _RowDetailCellState extends State<_RowDetailCell> {
behavior: HitTestBehavior.translucent,
onTap: () => cell.beginFocus.notify(),
child: AccessoryHover(
contentPadding:
const EdgeInsets.symmetric(horizontal: 10, vertical: 12),
contentPadding: const EdgeInsets.symmetric(horizontal: 3, vertical: 3),
child: cell,
),
);
return IntrinsicHeight(
child: ConstrainedBox(
constraints: const BoxConstraints(minHeight: 40),
constraints: const BoxConstraints(minHeight: 30),
child: Row(
crossAxisAlignment: CrossAxisAlignment.stretch,
mainAxisAlignment: MainAxisAlignment.center,
@ -287,9 +286,7 @@ class _RowDetailCellState extends State<_RowDetailCell> {
child: FieldCellButton(
maxLines: null,
field: widget.cellId.fieldContext.field,
onTap: () {
popover.show();
},
onTap: () => popover.show(),
),
),
),

3
frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart
View File

@ -31,7 +31,8 @@ class FlowyButton extends StatelessWidget {
@override
Widget build(BuildContext context) {
return InkWell(
return GestureDetector(
behavior: HitTestBehavior.opaque,
onTap: onTap,
child: FlowyHover(
style: HoverStyle(