Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Optimize LinkTextField state management

Browse Source
This commit is contained in:
Sean Siders 2024-08-13 10:49:11 -07:00
parent ed8d4c17fe
commit 4435343f0e
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_url_cell.dart
View File

@ -48,12 +48,13 @@ class LinkTextField extends StatefulWidget {
final TextEditingController controller;
final FocusNode focusNode;
@override
State<LinkTextField> createState() => _LinkTextFieldState();
}
class _LinkTextFieldState extends State<LinkTextField> {
bool _isLinkClickable = false;
bool isLinkClickable = false;
@override
void initState() {
@ -68,17 +69,12 @@ class _LinkTextFieldState extends State<LinkTextField> {
}
bool _handleGlobalKeyEvent(KeyEvent event) {
setState(() {
_isLinkClickable = event is KeyDownEvent &&
[
LogicalKeyboardKey.control,
LogicalKeyboardKey.controlLeft,
LogicalKeyboardKey.controlRight,
LogicalKeyboardKey.meta,
LogicalKeyboardKey.metaLeft,
LogicalKeyboardKey.metaRight,
].contains(event.logicalKey);
});
final keyboard = HardwareKeyboard.instance;
final canOpenLink = event is KeyDownEvent &&
(keyboard.isControlPressed || keyboard.isMetaPressed);
if (canOpenLink != isLinkClickable) {
setState(() => isLinkClickable = canOpenLink);
}
return false;
}
@ -87,7 +83,7 @@ class _LinkTextFieldState extends State<LinkTextField> {
Widget build(BuildContext context) {
return TextField(
mouseCursor:
_isLinkClickable ? SystemMouseCursors.click : SystemMouseCursors.text,
isLinkClickable ? SystemMouseCursors.click : SystemMouseCursors.text,
controller: widget.controller,
focusNode: widget.focusNode,
style: Theme.of(context).textTheme.bodyMedium?.copyWith(
@ -95,7 +91,7 @@ class _LinkTextFieldState extends State<LinkTextField> {
decoration: TextDecoration.underline,
),
onTap: () {
if (_isLinkClickable) {
if (isLinkClickable) {
openUrlCellLink(widget.controller.text);
}
},