Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: number and select filter logic (#4828)

Browse Source 
* fix: number and select option filter bugs

* chore: rename filter condition enum and variants
This commit is contained in:
Richard Shiue
2024-03-14 14:27:57 +08:00
committed by GitHub
parent 1a34366a3f
commit 5a837a9482
57 changed files with 1338 additions and 1266 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_menu_test.dart
View File

@ -55,13 +55,13 @@ void main() {
await service.insertTextFilter(
fieldId: textField.id,
filterId: textFilter.filter.id,
condition: TextFilterConditionPB.Is,
condition: TextFilterConditionPB.TextIs,
content: "ABC",
);
await gridResponseFuture();
assert(
menuBloc.state.filters.first.textFilter()!.condition ==
TextFilterConditionPB.Is,
TextFilterConditionPB.TextIs,
);
assert(menuBloc.state.filters.first.textFilter()!.content == "ABC");
});

8
frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_rows_by_text_test.dart
View File

@ -118,7 +118,7 @@ void main() {
// create a new filter
await service.insertTextFilter(
fieldId: textField.id,
condition: TextFilterConditionPB.Is,
condition: TextFilterConditionPB.TextIs,
content: "A",
);
await gridResponseFuture();
@ -132,7 +132,7 @@ void main() {
await service.insertTextFilter(
fieldId: textField.id,
filterId: textFilter.filter.id,
condition: TextFilterConditionPB.Is,
condition: TextFilterConditionPB.TextIs,
content: "B",
);
await gridResponseFuture();
@ -142,7 +142,7 @@ void main() {
await service.insertTextFilter(
fieldId: textField.id,
filterId: textFilter.filter.id,
condition: TextFilterConditionPB.Is,
condition: TextFilterConditionPB.TextIs,
content: "b",
);
await gridResponseFuture();
@ -152,7 +152,7 @@ void main() {
await service.insertTextFilter(
fieldId: textField.id,
filterId: textFilter.filter.id,
condition: TextFilterConditionPB.Is,
condition: TextFilterConditionPB.TextIs,
content: "C",
);
await gridResponseFuture();