diff --git a/.github/workflows/flutter_ci.yaml b/.github/workflows/flutter_ci.yaml index 0b8a9e141a..9dcb076565 100644 --- a/.github/workflows/flutter_ci.yaml +++ b/.github/workflows/flutter_ci.yaml @@ -102,6 +102,7 @@ jobs: git config --system core.longpaths true flutter config --enable-windows-desktop fi + dart pub global activate protoc_plugin 20.0.1 shell: bash - name: Build AppFlowy @@ -119,10 +120,16 @@ jobs: run: | cargo make dart_unit_test - - uses: codecov/codecov-action@v3 + - name: Upload coverage to Codecov + uses: Wandalen/wretry.action@master with: - name: appflowy - flags: appflowy_flutter_unit_test - fail_ci_if_error: true - verbose: true - os: ${{ matrix.os }} + action: codecov/codecov-action@v3 + with: | + name: appflowy + flags: appflowy_flutter_unit_test + fail_ci_if_error: true + verbose: true + os: ${{ matrix.os }} + attempt_limit: 5 + attempt_delay: 10000 + diff --git a/.github/workflows/integration_test.yml b/.github/workflows/integration_test.yml index 2171a5f4c3..7f3a9126c9 100644 --- a/.github/workflows/integration_test.yml +++ b/.github/workflows/integration_test.yml @@ -92,6 +92,7 @@ jobs: elif [ "$RUNNER_OS" == "Windows" ]; then flutter config --enable-windows-desktop fi + dart pub global activate protoc_plugin 20.0.1 shell: bash - name: Build Test lib @@ -121,10 +122,15 @@ jobs: fi shell: bash - - uses: codecov/codecov-action@v3 + - name: Upload coverage to Codecov + uses: Wandalen/wretry.action@master with: - name: appflowy - flags: appflowy_flutter_integrateion_test - fail_ci_if_error: true - verbose: true - os: ${{ matrix.os }} + action: codecov/codecov-action@v3 + with: | + name: appflowy + flags: appflowy_flutter_integrateion_test + fail_ci_if_error: true + verbose: true + os: ${{ matrix.os }} + attempt_limit: 5 + attempt_delay: 10000 \ No newline at end of file diff --git a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart index 0227a47b67..30d8af6664 100644 --- a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart +++ b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart @@ -107,6 +107,7 @@ class _AppFlowyEditorPageState extends State { if (widget.scrollController == null) { effectiveScrollController.dispose(); } + super.dispose(); }