fix: memory leaks (#3995)

* feat: add memory leak monitor

* fix: memory leaks

* feat: dump call stack in memory leak detector

* chore: disable memory leak detector

frontend/appflowy_flutter/lib/plugins/database_view/application/field/field_editor_bloc.dart

@@ -3,8 +3,8 @@ import 'package:appflowy_backend/log.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/field_entities.pb.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/field_settings_entities.pbenum.dart';
 import 'package:appflowy_backend/protobuf/flowy-error/errors.pb.dart';
-import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:dartz/dartz.dart';
+import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:freezed_annotation/freezed_annotation.dart';
 
 import 'field_controller.dart';
@@ -109,6 +109,7 @@ class FieldEditorBloc extends Bloc<FieldEditorEvent, FieldEditorState> {
   @override
   Future<void> close() {
     _singleFieldListener.stop();
+
     return super.close();
   }
 }
@@ -116,11 +117,11 @@ class FieldEditorBloc extends Bloc<FieldEditorEvent, FieldEditorState> {
 @freezed
 class FieldEditorEvent with _$FieldEditorEvent {
   const factory FieldEditorEvent.initial() = _InitialField;
-  const factory FieldEditorEvent.didReceiveFieldChanged(String fieldId) =
+  const factory FieldEditorEvent.didReceiveFieldChanged(final String fieldId) =
       _DidReceiveFieldChanged;
-  const factory FieldEditorEvent.switchFieldType(FieldType fieldType) =
+  const factory FieldEditorEvent.switchFieldType(final FieldType fieldType) =
       _SwitchFieldType;
-  const factory FieldEditorEvent.renameField(String name) = _RenameField;
+  const factory FieldEditorEvent.renameField(final String name) = _RenameField;
   const factory FieldEditorEvent.toggleFieldVisibility() =
       _ToggleFieldVisiblity;
   const factory FieldEditorEvent.deleteField() = _DeleteField;
@@ -130,6 +131,6 @@ class FieldEditorEvent with _$FieldEditorEvent {
 @freezed
 class FieldEditorState with _$FieldEditorState {
   const factory FieldEditorState({
-    required FieldInfo field,
+    required final FieldInfo field,
   }) = _FieldEditorState;
 }

frontend/appflowy_flutter/lib/plugins/database_view/application/field/type_option/type_option_data_controller.dart

@@ -1,10 +1,10 @@
 import 'package:appflowy_backend/dispatch/dispatch.dart';
-import 'package:flowy_infra/notifier.dart';
-import 'package:appflowy_backend/protobuf/flowy-error/errors.pb.dart';
-import 'package:appflowy_backend/protobuf/flowy-database2/field_entities.pb.dart';
-import 'package:dartz/dartz.dart';
-import 'package:protobuf/protobuf.dart' hide FieldInfo;
 import 'package:appflowy_backend/log.dart';
+import 'package:appflowy_backend/protobuf/flowy-database2/field_entities.pb.dart';
+import 'package:appflowy_backend/protobuf/flowy-error/errors.pb.dart';
+import 'package:dartz/dartz.dart';
+import 'package:flowy_infra/notifier.dart';
+import 'package:protobuf/protobuf.dart' hide FieldInfo;
 
 import '../field_service.dart';
 import 'type_option_context.dart';
@@ -110,4 +110,8 @@ class TypeOptionController {
   void removeFieldListener(void Function() listener) {
     _fieldNotifier.removeListener(listener);
   }
+
+  void dispose() {
+    _fieldNotifier.dispose();
+  }
 }

frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart

@@ -12,8 +12,8 @@ import 'package:appflowy/plugins/database_view/grid/presentation/widgets/header/
 import 'package:appflowy/plugins/database_view/tab_bar/tab_bar_view.dart';
 import 'package:appflowy/plugins/database_view/widgets/row/row_detail.dart';
 import 'package:appflowy/util/platform_extension.dart';
-import 'package:appflowy_backend/protobuf/flowy-folder2/view.pb.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/row_entities.pb.dart';
+import 'package:appflowy_backend/protobuf/flowy-folder2/view.pb.dart';
 import 'package:appflowy_board/appflowy_board.dart';
 import 'package:easy_localization/easy_localization.dart';
 import 'package:flowy_infra_ui/flowy_infra_ui.dart';
@@ -25,11 +25,11 @@ import 'package:flutter/services.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:go_router/go_router.dart';
 
-import '../../widgets/card/cells/card_cell.dart';
+import '../../widgets/card/card.dart';
 import '../../widgets/card/card_cell_builder.dart';
+import '../../widgets/card/cells/card_cell.dart';
 import '../../widgets/row/cell_builder.dart';
 import '../application/board_bloc.dart';
-import '../../widgets/card/card.dart';
 import 'toolbar/board_setting_bar.dart';
 import 'widgets/board_hidden_groups.dart';
 
@@ -383,11 +383,15 @@ class _BoardTrailingState extends State<BoardTrailing> {
         }
         return KeyEventResult.ignored;
       },
-    )..addListener(() {
-        if (!_focusNode.hasFocus) {
-          _cancelAddNewGroup();
-        }
-      });
+    )..addListener(_onFocusChanged);
+  }
+
+  @override
+  void dispose() {
+    _focusNode.removeListener(_onFocusChanged);
+    _focusNode.dispose();
+    _textController.dispose();
+    super.dispose();
   }
 
   @override
@@ -452,4 +456,10 @@ class _BoardTrailingState extends State<BoardTrailing> {
       ),
     );
   }
+
+  void _onFocusChanged() {
+    if (!_focusNode.hasFocus) {
+      _cancelAddNewGroup();
+    }
+  }
 }

frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_editor.dart

@@ -9,12 +9,13 @@ import 'package:appflowy/plugins/database_view/grid/presentation/layout/sizes.da
 import 'package:appflowy/plugins/database_view/grid/presentation/widgets/common/type_option_separator.dart';
 import 'package:appflowy/workspace/presentation/widgets/dialogs.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/field_entities.pb.dart';
+import 'package:appflowy_backend/protobuf/flowy-database2/field_settings_entities.pb.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/field_settings_entities.pbenum.dart';
 import 'package:appflowy_popover/appflowy_popover.dart';
+import 'package:easy_localization/easy_localization.dart';
 import 'package:flowy_infra_ui/flowy_infra_ui.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
-import 'package:easy_localization/easy_localization.dart';
 import 'package:styled_widget/styled_widget.dart';
 
 import 'field_type_option_editor.dart';

frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/row/row.dart

@@ -1,10 +1,12 @@
 import 'package:appflowy/generated/flowy_svgs.g.dart';
+import "package:appflowy/generated/locale_keys.g.dart";
 import 'package:appflowy/plugins/database_view/application/cell/cell_service.dart';
 import 'package:appflowy/plugins/database_view/application/row/row_controller.dart';
 import 'package:appflowy/plugins/database_view/application/row/row_service.dart';
 import 'package:appflowy/plugins/database_view/grid/application/row/row_bloc.dart';
 import 'package:appflowy/plugins/database_view/widgets/row/cell_builder.dart';
 import 'package:appflowy_popover/appflowy_popover.dart';
+import 'package:easy_localization/easy_localization.dart';
 import 'package:flowy_infra/theme_extension.dart';
 import 'package:flowy_infra_ui/flowy_infra_ui.dart';
 import 'package:flutter/foundation.dart';
@@ -13,11 +15,9 @@ import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:provider/provider.dart';
 
 import '../../../../widgets/row/accessory/cell_accessory.dart';
-import '../../layout/sizes.dart';
 import '../../../../widgets/row/cells/cell_container.dart';
+import '../../layout/sizes.dart';
 import 'action.dart';
-import "package:appflowy/generated/locale_keys.g.dart";
-import 'package:easy_localization/easy_localization.dart';
 
 class GridRow extends StatefulWidget {
   final RowId viewId;
@@ -267,7 +267,6 @@ class RowContent extends StatelessWidget {
     return cellByFieldId.values.map(
       (cellId) {
         final GridCellWidget child = builder.build(cellId);
-
         return CellContainer(
           width: cellId.fieldInfo.fieldSettings?.width.toDouble() ?? 140,
           isPrimary: cellId.fieldInfo.field.isPrimary,

frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart

@@ -5,15 +5,15 @@ import 'package:appflowy/plugins/database_view/grid/presentation/widgets/row/act
 import 'package:appflowy/util/platform_extension.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/row_entities.pb.dart';
 import 'package:appflowy_popover/appflowy_popover.dart';
-
 import 'package:flowy_infra_ui/flowy_infra_ui.dart';
 import 'package:flowy_infra_ui/style_widget/hover.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
+
 import 'card_bloc.dart';
-import 'cells/card_cell.dart';
 import 'card_cell_builder.dart';
+import 'cells/card_cell.dart';
 import 'container/accessory.dart';
 import 'container/card_container.dart';
 
@@ -193,7 +193,7 @@ class _RowCardState<T> extends State<RowCard<T>> {
   }
 }
 
-class _CardContent<CustomCardData> extends StatelessWidget {
+class _CardContent<CustomCardData> extends StatefulWidget {
   const _CardContent({
     super.key,
     required this.rowNotifier,
@@ -211,26 +211,44 @@ class _CardContent<CustomCardData> extends StatelessWidget {
   final CustomCardData? cardData;
   final RowCardStyleConfiguration styleConfiguration;
 
+  @override
+  State<_CardContent<CustomCardData>> createState() =>
+      _CardContentState<CustomCardData>();
+}
+
+class _CardContentState<CustomCardData>
+    extends State<_CardContent<CustomCardData>> {
+  final List<EditableCardNotifier> _notifiers = [];
+
+  @override
+  void dispose() {
+    for (final element in _notifiers) {
+      element.dispose();
+    }
+    _notifiers.clear();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
-    if (styleConfiguration.hoverStyle != null) {
+    if (widget.styleConfiguration.hoverStyle != null) {
       return FlowyHover(
-        style: styleConfiguration.hoverStyle,
-        buildWhenOnHover: () => !rowNotifier.isEditing.value,
+        style: widget.styleConfiguration.hoverStyle,
+        buildWhenOnHover: () => !widget.rowNotifier.isEditing.value,
         child: Padding(
-          padding: styleConfiguration.cardPadding,
+          padding: widget.styleConfiguration.cardPadding,
           child: Column(
             mainAxisSize: MainAxisSize.min,
-            children: _makeCells(context, cells),
+            children: _makeCells(context, widget.cells),
           ),
         ),
       );
     }
     return Padding(
-      padding: styleConfiguration.cardPadding,
+      padding: widget.styleConfiguration.cardPadding,
       child: Column(
         mainAxisSize: MainAxisSize.min,
-        children: _makeCells(context, cells),
+        children: _makeCells(context, widget.cells),
       ),
     );
   }
@@ -241,26 +259,28 @@ class _CardContent<CustomCardData> extends StatelessWidget {
   ) {
     final List<Widget> children = [];
     // Remove all the cell listeners.
-    rowNotifier.unbind();
+    widget.rowNotifier.unbind();
 
     cells.asMap().forEach((int index, DatabaseCellContext cellContext) {
-      final isEditing = index == 0 ? rowNotifier.isEditing.value : false;
+      final isEditing = index == 0 ? widget.rowNotifier.isEditing.value : false;
       final cellNotifier = EditableCardNotifier(isEditing: isEditing);
 
       if (index == 0) {
         // Only use the first cell to receive user's input when click the edit
         // button
-        rowNotifier.bindCell(cellContext, cellNotifier);
+        widget.rowNotifier.bindCell(cellContext, cellNotifier);
+      } else {
+        _notifiers.add(cellNotifier);
       }
 
       final child = Padding(
         key: cellContext.key(),
-        padding: styleConfiguration.cellPadding,
-        child: cellBuilder.buildCell(
+        padding: widget.styleConfiguration.cellPadding,
+        child: widget.cellBuilder.buildCell(
           cellContext: cellContext,
           cellNotifier: cellNotifier,
-          renderHook: renderHook,
-          cardData: cardData,
+          renderHook: widget.renderHook,
+          cardData: widget.cardData,
           hasNotes: !cellContext.rowMeta.isDocumentEmpty,
         ),
       );

frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/card_cell.dart

@@ -1,9 +1,9 @@
 import 'package:appflowy/plugins/database_view/application/cell/cell_service.dart';
 import 'package:appflowy/plugins/database_view/application/row/row_service.dart';
+import 'package:appflowy_backend/log.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/date_entities.pb.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/field_entities.pbenum.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/select_option.pb.dart';
-import 'package:appflowy_backend/log.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/timestamp_entities.pb.dart';
 import 'package:flutter/material.dart';
 
@@ -160,11 +160,8 @@ class EditableRowNotifier {
   }
 
   void dispose() {
-    for (final notifier in _cells.values) {
-      notifier.dispose();
-    }
-
-    _cells.clear();
+    unbind();
+    isEditing.dispose();
   }
 }
 

frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cell_builder.dart

@@ -2,8 +2,9 @@ import 'package:appflowy/mobile/presentation/database/card/row/cells/cells.dart'
 import 'package:appflowy/plugins/database_view/application/cell/cell_controller_builder.dart';
 import 'package:appflowy/util/platform_extension.dart';
 import 'package:appflowy_backend/protobuf/flowy-database2/field_entities.pb.dart';
-import 'package:flutter/widgets.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter/widgets.dart';
+
 import '../../application/cell/cell_service.dart';
 import 'accessory/cell_accessory.dart';
 import 'accessory/cell_shortcuts.dart';
@@ -263,7 +264,9 @@ abstract class GridCellState<T extends GridCellWidget> extends State<T> {
 
   @override
   void dispose() {
+    widget.onAccessoryHover.dispose();
     widget.requestFocus.removeAllListener();
+    widget.requestFocus.dispose();
     super.dispose();
   }
 
@@ -336,6 +339,7 @@ class RequestFocusListener extends ChangeNotifier {
   void removeAllListener() {
     if (_listener != null) {
       removeListener(_listener!);
+      _listener = null;
     }
   }
 

frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/text_cell/text_cell.dart

@@ -1,9 +1,11 @@
 import 'dart:async';
+
 import 'package:appflowy/plugins/database_view/application/cell/cell_controller_builder.dart';
 import 'package:appflowy/plugins/database_view/widgets/row/cells/text_cell/text_cell_bloc.dart';
 import 'package:flowy_infra_ui/flowy_infra_ui.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
+
 import '../../../../grid/presentation/layout/sizes.dart';
 import '../../cell_builder.dart';
 
@@ -141,6 +143,7 @@ class _GridTextCellState extends GridEditableTextCell<GridTextCell> {
 
   @override
   Future<void> dispose() async {
+    _controller.dispose();
     _cellBloc.close();
     super.dispose();
   }