Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1137 from AppFlowy-IO/fix/format_date_fail

Browse Source 
fix: switch format style of the date after creating
This commit is contained in:
Nathan.fooo 2022-09-23 16:22:17 +08:00 committed by GitHub
commit 7de6a21331
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
frontend/app_flowy/lib/plugins/grid/application/cell/cell_service/cell_controller.dart
View File

@ -149,18 +149,13 @@ class IGridCellController<T, D> extends Equatable {
_cellDataPersistence = cellDataPersistence,
_fieldNotifier = fieldNotifier,
_fieldService = FieldService(
gridId: cellId.gridId, fieldId: cellId.fieldContext.id),
gridId: cellId.gridId,
fieldId: cellId.fieldContext.id,
),
_cacheKey = GridCellCacheKey(
rowId: cellId.rowId, fieldId: cellId.fieldContext.id);
IGridCellController<T, D> clone() {
return IGridCellController(
cellId: cellId,
cellDataLoader: _cellDataLoader,
cellCache: _cellsCache,
fieldNotifier: _fieldNotifier,
cellDataPersistence: _cellDataPersistence);
}
rowId: cellId.rowId,
fieldId: cellId.fieldContext.id,
);
String get gridId => cellId.gridId;
@ -172,9 +167,10 @@ class IGridCellController<T, D> extends Equatable {
FieldType get fieldType => cellId.fieldContext.fieldType;
VoidCallback? startListening(
{required void Function(T?) onCellChanged,
VoidCallback? onCellFieldChanged}) {
VoidCallback? startListening({
required void Function(T?) onCellChanged,
VoidCallback? onCellFieldChanged,
}) {
if (isListening) {
Log.error("Already started. It seems like you should call clone first");
return null;

4
frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart
View File

@ -80,9 +80,9 @@ class _DateCellState extends GridCellState<GridDateCell> {
),
),
popupBuilder: (BuildContext popoverContent) {
final bloc = context.read<DateCellBloc>();
return DateCellEditor(
cellController: bloc.cellController.clone(),
cellController: widget.cellControllerBuilder.build()
as GridDateCellController,
onDismissed: () => widget.onCellEditing.value = false,
);
},

11
frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/url_cell.dart
View File

@ -54,13 +54,11 @@ class GridURLCell extends GridCellWidget {
GridURLCellAccessoryType ty, GridCellAccessoryBuildContext buildContext) {
switch (ty) {
case GridURLCellAccessoryType.edit:
final cellController =
cellControllerBuilder.build() as GridURLCellController;
return GridCellAccessoryBuilder(
builder: (Key key) => _EditURLAccessory(
key: key,
cellContext: cellController,
anchorContext: buildContext.anchorContext,
cellControllerBuilder: cellControllerBuilder,
),
);
@ -191,10 +189,10 @@ class _GridURLCellState extends GridCellState<GridURLCell> {
}
class _EditURLAccessory extends StatefulWidget {
final GridURLCellController cellContext;
final GridCellControllerBuilder cellControllerBuilder;
final BuildContext anchorContext;
const _EditURLAccessory({
required this.cellContext,
required this.cellControllerBuilder,
required this.anchorContext,
Key? key,
}) : super(key: key);
@ -224,7 +222,8 @@ class _EditURLAccessoryState extends State<_EditURLAccessory>
child: svgWidget("editor/edit", color: theme.iconColor),
popupBuilder: (BuildContext popoverContext) {
return URLEditorPopover(
cellController: widget.cellContext.clone(),
cellController:
widget.cellControllerBuilder.build() as GridURLCellController,
);
},
);