Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: sign in toast issue (#4895)

Browse Source
This commit is contained in:
Lucas.Xu 2024-03-14 09:17:59 +08:00 committed by GitHub
parent b57a870242
commit 80e210b34a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart
View File

@ -27,8 +27,7 @@ Future<bool> afLaunchUrl(
); );
} on PlatformException catch (e) { } on PlatformException catch (e) {
Log.error('Failed to open uri: $e'); Log.error('Failed to open uri: $e');
} finally { return false;
result = false;
} }
// if the uri is not a valid url, try to launch it with http scheme // if the uri is not a valid url, try to launch it with http scheme

7
frontend/appflowy_flutter/lib/startup/tasks/appflowy_cloud_task.dart
View File

@ -89,8 +89,10 @@ class AppFlowyCloudDeepLink {
Log.error('onDeepLinkError: Unexpected empty deep link callback'); Log.error('onDeepLinkError: Unexpected empty deep link callback');
_completer?.complete(FlowyResult.failure(AuthError.emptyDeepLink)); _completer?.complete(FlowyResult.failure(AuthError.emptyDeepLink));
_completer = null; _completer = null;
return;
} }
return _isAuthCallbackDeepLink(uri!).fold(
return _isAuthCallbackDeepLink(uri).fold(
(_) async { (_) async {
final deviceId = await getDeviceId(); final deviceId = await getDeviceId();
final payload = OauthSignInPB( final payload = OauthSignInPB(
@ -101,8 +103,7 @@ class AppFlowyCloudDeepLink {
}, },
); );
_stateNotifier?.value = DeepLinkResult(state: DeepLinkState.loading); _stateNotifier?.value = DeepLinkResult(state: DeepLinkState.loading);
final result = final result = await UserEventOauthSignIn(payload).send();
await UserEventOauthSignIn(payload).send().then((value) => value);
_stateNotifier?.value = DeepLinkResult( _stateNotifier?.value = DeepLinkResult(
state: DeepLinkState.finish, state: DeepLinkState.finish,

5
frontend/appflowy_flutter/lib/user/application/auth/af_cloud_auth_service.dart
View File

@ -72,8 +72,9 @@ class AppFlowyCloudAuthService implements AuthService {
throw Exception('AppFlowyCloudDeepLink is not registered'); throw Exception('AppFlowyCloudDeepLink is not registered');
} }
} else { } else {
completer completer.complete(
.complete(FlowyResult.failure(AuthError.signInWithOauthError)); FlowyResult.failure(AuthError.unableToGetDeepLink),
);
} }
return completer.future; return completer.future;

4
frontend/appflowy_flutter/lib/user/application/auth/auth_error.dart
View File

@ -29,4 +29,8 @@ class AuthError {
static final deepLinkError = FlowyError() static final deepLinkError = FlowyError()
..msg = 'DeepLink error' ..msg = 'DeepLink error'
..code = ErrorCode.Internal; ..code = ErrorCode.Internal;
static final unableToGetDeepLink = FlowyError()
..msg = 'Unable to get the deep link'
..code = ErrorCode.Internal;
} }