fix: scrolling selection-menu when it goes out of bound, fixes #2019 (#2035)

* fix: scrolling selection-menu when it goes out of bound

* refactor: added comma as per style guidelines
This commit is contained in:
Samiksha Garg 2023-03-20 18:41:47 +05:30 committed by GitHub
parent 81e50b8dd5
commit 893aae002e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -91,20 +91,24 @@ class SelectionMenu implements SelectionMenuService {
top: showBelow ? _offset.dy : null, top: showBelow ? _offset.dy : null,
bottom: showBelow ? null : _offset.dy, bottom: showBelow ? null : _offset.dy,
left: offset.dx, left: offset.dx,
child: SelectionMenuWidget( right: 0,
items: [ child: SingleChildScrollView(
..._defaultSelectionMenuItems, scrollDirection: Axis.horizontal,
...editorState.selectionMenuItems, child: SelectionMenuWidget(
], items: [
maxItemInRow: 5, ..._defaultSelectionMenuItems,
editorState: editorState, ...editorState.selectionMenuItems,
menuService: this, ],
onExit: () { maxItemInRow: 5,
dismiss(); editorState: editorState,
}, menuService: this,
onSelectionUpdate: () { onExit: () {
_selectionUpdateByInner = true; dismiss();
}, },
onSelectionUpdate: () {
_selectionUpdateByInner = true;
},
),
), ),
); );
}); });