Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1390 from LucasXu0/fix_enter_key_handler

Browse Source 
fix: remove the unnecessary operation in enter key handler
This commit is contained in:
Lucas.Xu 2022-10-29 16:56:07 +08:00 committed by GitHub
commit 95fdfd7da2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/enter_without_shift_in_text_node_handler.dart
View File

@ -153,11 +153,13 @@ ShortcutEventHandler enterWithoutShiftInTextNodesHandler =
delta: textNode.delta.slice(selection.end.offset), delta: textNode.delta.slice(selection.end.offset),
), ),
); );
if (selection.end.offset != textNode.toPlainText().length) {
transaction.deleteText( transaction.deleteText(
textNode, textNode,
selection.start.offset, selection.start.offset,
textNode.toPlainText().length - selection.start.offset, textNode.toPlainText().length - selection.start.offset,
); );
}
if (textNode.children.isNotEmpty) { if (textNode.children.isNotEmpty) {
final children = textNode.children.toList(growable: false); final children = textNode.children.toList(growable: false);
transaction.deleteNodes(children); transaction.deleteNodes(children);

8
frontend/app_flowy/packages/appflowy_editor/lib/src/service/render_plugin_service.dart
View File

@ -78,10 +78,10 @@ class AppFlowyRenderPlugin extends AppFlowyRenderPluginService {
node.key = key; node.key = key;
return _autoUpdateNodeWidget(builder, context); return _autoUpdateNodeWidget(builder, context);
} else { } else {
assert(false, // Returns a SizeBox with 0 height if no builder found.
'Could not query the builder with this $name, or nodeValidator return false.'); return const SizedBox(
// TODO: return a placeholder widget with tips. height: 0,
return Container(); );
} }
} }