Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: optimize protobuf code gen process

Browse Source
This commit is contained in:
appflowy
2022-02-13 12:04:34 +08:00
parent 9434bff9c9
commit 9b8c110a66
12 changed files with 115 additions and 195 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shared-lib/lib-infra/Cargo.toml
View File

@ -30,7 +30,7 @@ tera = { version = "1.5.0", optional = true}
itertools = { version = "0.10", optional = true }
phf = { version = "0.8.0", features = ["macros"], optional = true }
console = {version = "0.14.0", optional = true}
protoc-bin-vendored = { version = "3.0", optional = true }
toml = {version = "0.5.8", optional = true}
[features]
@ -47,5 +47,5 @@ proto_gen = [
"console",
"toml"
]
pb_gen = ["cmd_lib", "protoc-rust", "walkdir"]
pb_gen = ["cmd_lib", "protoc-rust", "walkdir", "protoc-bin-vendored",]
dart = ["proto_gen"]

16
shared-lib/lib-infra/src/pb.rs
View File

@ -7,6 +7,7 @@ use crate::proto_gen::*;
use log::info;
use std::fs::File;
use std::io::Write;
use std::path::PathBuf;
use std::process::Command;
use walkdir::WalkDir;
@ -30,11 +31,14 @@ pub fn gen_files(crate_name: &str, root: &str) {
}
}
println!("cargo:rerun-if-changed=build.rs");
let protoc_path = protoc_bin_vendored::protoc_bin_path().unwrap();
#[cfg(feature = "dart")]
gen_pb_for_dart(crate_name, root, &paths, &file_names);
gen_pb_for_dart(crate_name, root, &paths, &file_names, &protoc_path);
protoc_rust::Codegen::new()
.out_dir("./src/protobuf/model")
.protoc_path(protoc_path)
.inputs(&paths)
.include(root)
.run()
@ -42,7 +46,7 @@ pub fn gen_files(crate_name: &str, root: &str) {
}
#[cfg(feature = "dart")]
fn gen_pb_for_dart(name: &str, root: &str, paths: &Vec<String>, file_names: &Vec<String>) {
fn gen_pb_for_dart(name: &str, root: &str, paths: &Vec<String>, file_names: &Vec<String>, proto_path: &PathBuf) {
if std::env::var("CARGO_MAKE_WORKING_DIRECTORY").is_err() {
log::warn!("CARGO_MAKE_WORKING_DIRECTORY was not set, skip generate dart pb");
return;
@ -59,17 +63,15 @@ fn gen_pb_for_dart(name: &str, root: &str, paths: &Vec<String>, file_names: &Vec
if !std::path::Path::new(&output).exists() {
std::fs::create_dir_all(&output).unwrap();
}
check_pb_compiler();
check_pb_dart_plugin();
let proto_path = proto_path.to_str().unwrap().to_owned();
paths.iter().for_each(|path| {
if cmd_lib::run_cmd! {
protoc --dart_out=${output} --proto_path=${root} ${path}
${proto_path} --dart_out=${output} --proto_path=${root} ${path}
}
.is_err()
{
panic!("Generate pb file failed with: {}", path)
panic!("Generate dart pb file failed with: {}", path)
};
});