From 2e7ab3000f3aa2979fa8d09ed959cf3a28bc15cd Mon Sep 17 00:00:00 2001 From: Daniel Thompson Date: Sat, 4 Dec 2021 17:43:41 -0500 Subject: [PATCH] Correct the capitalization of GitHub To accomplish this task, I ran the following command (on macOS): find . -type f -print0 | xargs -0 sed -i '' 's/Github/GitHub/g' GitHub, for better or worse, decided that the way their company is spelled is with a capital "G" and a capital "H" and it's their name so they get to do that if they want. When I went to check out AppFlowy's web site, I noticed that GitHub wasn't spelled correctly, and for me, this made the project feel less than polished and myself reluctant to try it out. However, there is only one way to find out about the project: I [opened a ticket]. And BAM! It was resolved in mere hours by @annieappflowy. Nice. With fresh motivation to check out the project, I downloaded the app and...found myself staring at the same issue on the first screen of the app. Well, as I was a bit flippant with the issue I opened up for the web site misspellings, I decided to fix this one myself. [opened a ticket]: https://github.com/AppFlowy-IO/appflowy/issues/118 --- .githooks/pre-commit | 2 +- frontend/rust-lib/flowy-test/src/workspace.rs | 4 ++-- .../flowy-workspace/tests/workspace/workspace_test.rs | 2 +- shared-lib/flowy-document-infra/src/READ_ME.json | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.githooks/pre-commit b/.githooks/pre-commit index 92b37ec498..d7617246c9 100755 --- a/.githooks/pre-commit +++ b/.githooks/pre-commit @@ -11,7 +11,7 @@ function file_too_large(){ cat < Self { let workspace = create_workspace(&test.sdk, "Workspace", "").await; open_workspace(&test.sdk, &workspace.id).await; - let app = create_app(&test.sdk, "App", "AppFlowy Github Project", &workspace.id).await; + let app = create_app(&test.sdk, "App", "AppFlowy GitHub Project", &workspace.id).await; let view = create_view(&test.sdk, &app.id).await; Self { sdk: test.sdk.clone(), diff --git a/frontend/rust-lib/flowy-workspace/tests/workspace/workspace_test.rs b/frontend/rust-lib/flowy-workspace/tests/workspace/workspace_test.rs index a0e9afc6c5..44e13f6664 100644 --- a/frontend/rust-lib/flowy-workspace/tests/workspace/workspace_test.rs +++ b/frontend/rust-lib/flowy-workspace/tests/workspace/workspace_test.rs @@ -28,7 +28,7 @@ async fn workspace_read() { #[tokio::test] async fn workspace_create_with_apps() { let test = WorkspaceTest::new().await; - let app = create_app(&test.sdk, "App A", "AppFlowy Github Project", &test.workspace.id).await; + let app = create_app(&test.sdk, "App A", "AppFlowy GitHub Project", &test.workspace.id).await; let request = QueryWorkspaceRequest::new(Some(test.workspace.id.clone())); let workspace_from_db = read_workspace(&test.sdk, request) .await diff --git a/shared-lib/flowy-document-infra/src/READ_ME.json b/shared-lib/flowy-document-infra/src/READ_ME.json index 2e0de59742..bb53eff10e 100644 --- a/shared-lib/flowy-document-infra/src/READ_ME.json +++ b/shared-lib/flowy-document-infra/src/READ_ME.json @@ -1 +1 @@ -[{"insert":"\nšŸ‘‹ Welcome to AppFlowy!"},{"insert":"\n","attributes":{"header":1}},{"insert":"\nHere are the basics"},{"insert":"\n","attributes":{"header":2}},{"insert":"Click anywhere and just start typing"},{"insert":"\n","attributes":{"list":"unchecked"}},{"insert":"Highlight","attributes":{"background":"#fff2cd"}},{"insert":" any text, and use the menu at the bottom to "},{"insert":"style","attributes":{"italic":true}},{"insert":" "},{"insert":"your","attributes":{"bold":true}},{"insert":" "},{"insert":"writing","attributes":{"underline":true}},{"insert":" "},{"insert":"however","attributes":{"code":true}},{"insert":" "},{"insert":"you","attributes":{"strike":true}},{"insert":" "},{"insert":"like","attributes":{"background":"#e8e0ff"}},{"insert":"\n","attributes":{"list":"unchecked"}},{"insert":"Click "},{"insert":"+ New Page","attributes":{"background":"#defff1","bold":true}},{"insert":" button at the bottom of your sidebar to add a new page"},{"insert":"\n","attributes":{"list":"unchecked"}},{"insert":"Click the "},{"insert":"'","attributes":{"background":"#defff1"}},{"insert":"+'","attributes":{"background":"#defff1","bold":true}},{"insert":" next to any page title in the sidebar to quickly add a new subpage"},{"insert":"\n","attributes":{"list":"unchecked"}},{"insert":"\nHave a question? "},{"insert":"\n","attributes":{"header":2}},{"insert":"Click the "},{"insert":"'?'","attributes":{"background":"#defff1","bold":true}},{"insert":" at the bottom right for help and support.\n\nLike AppFlowy? Follow us:"},{"insert":"\n","attributes":{"header":2}},{"insert":"Github: https://github.com/AppFlowy-IO/appflowy"},{"insert":"\n","attributes":{"blockquote":true}},{"insert":"Twitter: https://twitter.com/appflowy"},{"insert":"\n","attributes":{"blockquote":true}},{"insert":"Newsletter: https://www.appflowy.io/blog"},{"insert":"\n","attributes":{"blockquote":true}}] \ No newline at end of file +[{"insert":"\nšŸ‘‹ Welcome to AppFlowy!"},{"insert":"\n","attributes":{"header":1}},{"insert":"\nHere are the basics"},{"insert":"\n","attributes":{"header":2}},{"insert":"Click anywhere and just start typing"},{"insert":"\n","attributes":{"list":"unchecked"}},{"insert":"Highlight","attributes":{"background":"#fff2cd"}},{"insert":" any text, and use the menu at the bottom to "},{"insert":"style","attributes":{"italic":true}},{"insert":" "},{"insert":"your","attributes":{"bold":true}},{"insert":" "},{"insert":"writing","attributes":{"underline":true}},{"insert":" "},{"insert":"however","attributes":{"code":true}},{"insert":" "},{"insert":"you","attributes":{"strike":true}},{"insert":" "},{"insert":"like","attributes":{"background":"#e8e0ff"}},{"insert":"\n","attributes":{"list":"unchecked"}},{"insert":"Click "},{"insert":"+ New Page","attributes":{"background":"#defff1","bold":true}},{"insert":" button at the bottom of your sidebar to add a new page"},{"insert":"\n","attributes":{"list":"unchecked"}},{"insert":"Click the "},{"insert":"'","attributes":{"background":"#defff1"}},{"insert":"+'","attributes":{"background":"#defff1","bold":true}},{"insert":" next to any page title in the sidebar to quickly add a new subpage"},{"insert":"\n","attributes":{"list":"unchecked"}},{"insert":"\nHave a question? "},{"insert":"\n","attributes":{"header":2}},{"insert":"Click the "},{"insert":"'?'","attributes":{"background":"#defff1","bold":true}},{"insert":" at the bottom right for help and support.\n\nLike AppFlowy? Follow us:"},{"insert":"\n","attributes":{"header":2}},{"insert":"GitHub: https://github.com/AppFlowy-IO/appflowy"},{"insert":"\n","attributes":{"blockquote":true}},{"insert":"Twitter: https://twitter.com/appflowy"},{"insert":"\n","attributes":{"blockquote":true}},{"insert":"Newsletter: https://www.appflowy.io/blog"},{"insert":"\n","attributes":{"blockquote":true}}] \ No newline at end of file