chore: small code improvements

This commit is contained in:
Enzo Lizama 2022-10-04 11:37:59 -05:00
parent 6ea3ea189e
commit bf9f6ac13f

View File

@ -17,9 +17,9 @@ extension NodeAttributesExtensions on Attributes {
return containsKey(BuiltInAttributeKey.quote); return containsKey(BuiltInAttributeKey.quote);
} }
int? get number { num? get number {
if (containsKey(BuiltInAttributeKey.number) && if (containsKey(BuiltInAttributeKey.number) &&
this[BuiltInAttributeKey.number] is int) { this[BuiltInAttributeKey.number] is num) {
return this[BuiltInAttributeKey.number]; return this[BuiltInAttributeKey.number];
} }
return null; return null;
@ -27,7 +27,7 @@ extension NodeAttributesExtensions on Attributes {
bool get code { bool get code {
if (containsKey(BuiltInAttributeKey.code) && if (containsKey(BuiltInAttributeKey.code) &&
this[BuiltInAttributeKey.code] == true) { this[BuiltInAttributeKey.code] is bool) {
return this[BuiltInAttributeKey.code]; return this[BuiltInAttributeKey.code];
} }
return false; return false;
@ -63,11 +63,14 @@ extension DeltaAttributesExtensions on Attributes {
this[BuiltInAttributeKey.strikethrough] == true); this[BuiltInAttributeKey.strikethrough] == true);
} }
static const whiteInt = 0XFFFFFFFF;
Color? get color { Color? get color {
if (containsKey(BuiltInAttributeKey.color) && if (containsKey(BuiltInAttributeKey.color) &&
this[BuiltInAttributeKey.color] is String) { this[BuiltInAttributeKey.color] is String) {
return Color( return Color(
int.parse(this[BuiltInAttributeKey.color]), // If the parse fails returns white by default
int.tryParse(this[BuiltInAttributeKey.color]) ?? whiteInt,
); );
} }
return null; return null;
@ -77,8 +80,7 @@ extension DeltaAttributesExtensions on Attributes {
if (containsKey(BuiltInAttributeKey.backgroundColor) && if (containsKey(BuiltInAttributeKey.backgroundColor) &&
this[BuiltInAttributeKey.backgroundColor] is String) { this[BuiltInAttributeKey.backgroundColor] is String) {
return Color( return Color(
int.parse(this[BuiltInAttributeKey.backgroundColor]), int.tryParse(this[BuiltInAttributeKey.backgroundColor]) ?? whiteInt);
);
} }
return null; return null;
} }