chore: disable sync indicator (#5479)

This commit is contained in:
Lucas.Xu 2024-06-05 21:36:44 +08:00 committed by GitHub
parent 383e06ff2d
commit d73e388d01
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 4 additions and 35 deletions

View File

@ -6,7 +6,6 @@ import 'package:appflowy/mobile/presentation/base/view_page/app_bar_buttons.dart
import 'package:appflowy/mobile/presentation/widgets/flowy_mobile_state_container.dart'; import 'package:appflowy/mobile/presentation/widgets/flowy_mobile_state_container.dart';
import 'package:appflowy/plugins/base/emoji/emoji_text.dart'; import 'package:appflowy/plugins/base/emoji/emoji_text.dart';
import 'package:appflowy/plugins/document/presentation/document_collaborators.dart'; import 'package:appflowy/plugins/document/presentation/document_collaborators.dart';
import 'package:appflowy/plugins/shared/sync_indicator.dart';
import 'package:appflowy/shared/feature_flags.dart'; import 'package:appflowy/shared/feature_flags.dart';
import 'package:appflowy/startup/plugin/plugin.dart'; import 'package:appflowy/startup/plugin/plugin.dart';
import 'package:appflowy/startup/startup.dart'; import 'package:appflowy/startup/startup.dart';
@ -195,13 +194,6 @@ class _MobileViewPageState extends State<MobileViewPage> {
padding: const EdgeInsets.symmetric(vertical: 8), padding: const EdgeInsets.symmetric(vertical: 8),
view: view, view: view,
), ),
const HSpace(16.0),
DocumentSyncIndicator(view: view),
const HSpace(12.0),
]);
} else {
actions.addAll([
DatabaseSyncIndicator(view: view),
const HSpace(12.0), const HSpace(12.0),
]); ]);
} }

View File

@ -1,9 +1,7 @@
import 'package:appflowy/plugins/database/application/database_controller.dart'; import 'package:appflowy/plugins/database/application/database_controller.dart';
import 'package:appflowy/plugins/database/application/tab_bar_bloc.dart'; import 'package:appflowy/plugins/database/application/tab_bar_bloc.dart';
import 'package:appflowy/plugins/database/widgets/share_button.dart'; import 'package:appflowy/plugins/database/widgets/share_button.dart';
import 'package:appflowy/plugins/shared/sync_indicator.dart';
import 'package:appflowy/plugins/util.dart'; import 'package:appflowy/plugins/util.dart';
import 'package:appflowy/shared/feature_flags.dart';
import 'package:appflowy/startup/plugin/plugin.dart'; import 'package:appflowy/startup/plugin/plugin.dart';
import 'package:appflowy/workspace/application/view/view_bloc.dart'; import 'package:appflowy/workspace/application/view/view_bloc.dart';
import 'package:appflowy/workspace/application/view_info/view_info_bloc.dart'; import 'package:appflowy/workspace/application/view_info/view_info_bloc.dart';
@ -272,15 +270,6 @@ class DatabasePluginWidgetBuilder extends PluginWidgetBuilder {
value: bloc, value: bloc,
child: Row( child: Row(
children: [ children: [
...FeatureFlag.syncDatabase.isOn
? [
DatabaseSyncIndicator(
key: ValueKey('sync_state_${view.id}'),
view: view,
),
const HSpace(16),
]
: [],
DatabaseShareButton(key: ValueKey(view.id), view: view), DatabaseShareButton(key: ValueKey(view.id), view: view),
const HSpace(10), const HSpace(10),
ViewFavoriteButton(view: view), ViewFavoriteButton(view: view),

View File

@ -118,10 +118,6 @@ class _DatabaseDocumentPageState extends State<DatabaseDocumentPage> {
return Column( return Column(
children: [ children: [
// Only show the indicator in integration test mode
// if (FlowyRunner.currentMode.isIntegrationTest)
// const DocumentSyncIndicator(),
if (state.isDeleted) _buildBanner(context), if (state.isDeleted) _buildBanner(context),
Expanded(child: appflowyEditorPage), Expanded(child: appflowyEditorPage),
], ],

View File

@ -6,7 +6,6 @@ import 'package:appflowy/plugins/document/application/document_appearance_cubit.
import 'package:appflowy/plugins/document/document_page.dart'; import 'package:appflowy/plugins/document/document_page.dart';
import 'package:appflowy/plugins/document/presentation/document_collaborators.dart'; import 'package:appflowy/plugins/document/presentation/document_collaborators.dart';
import 'package:appflowy/plugins/document/presentation/share/share_button.dart'; import 'package:appflowy/plugins/document/presentation/share/share_button.dart';
import 'package:appflowy/plugins/shared/sync_indicator.dart';
import 'package:appflowy/plugins/util.dart'; import 'package:appflowy/plugins/util.dart';
import 'package:appflowy/shared/feature_flags.dart'; import 'package:appflowy/shared/feature_flags.dart';
import 'package:appflowy/startup/plugin/plugin.dart'; import 'package:appflowy/startup/plugin/plugin.dart';
@ -153,11 +152,6 @@ class DocumentPluginWidgetBuilder extends PluginWidgetBuilder
view: view, view: view,
), ),
const HSpace(16), const HSpace(16),
DocumentSyncIndicator(
key: ValueKey('sync_state_${view.id}'),
view: view,
),
const HSpace(16),
] ]
: [const HSpace(8)], : [const HSpace(8)],
DocumentShareButton( DocumentShareButton(

View File

@ -139,10 +139,6 @@ class _DocumentPageState extends State<DocumentPage>
return Column( return Column(
children: [ children: [
// Only show the indicator in integration test mode
// if (FlowyRunner.currentMode.isIntegrationTest)
// const DocumentSyncIndicator(),
if (state.isDeleted) _buildBanner(context), if (state.isDeleted) _buildBanner(context),
Expanded(child: child), Expanded(child: child),
], ],

View File

@ -143,6 +143,9 @@ class FlowyText extends StatelessWidget {
if (fontFamily != null && fallbackFontFamily == null) { if (fontFamily != null && fallbackFontFamily == null) {
fallbackFontFamily = [fontFamily]; fallbackFontFamily = [fontFamily];
} }
}
if (isEmoji && (_useNotoColorEmoji || Platform.isWindows)) {
fontSize = fontSize * 0.8; fontSize = fontSize * 0.8;
} }
@ -199,6 +202,5 @@ class FlowyText extends StatelessWidget {
return null; return null;
} }
bool get _useNotoColorEmoji => bool get _useNotoColorEmoji => Platform.isLinux || Platform.isAndroid;
Platform.isLinux || Platform.isAndroid || Platform.isWindows;
} }