chore: remove phantom where dragTarget disappear

This commit is contained in:
appflowy 2022-08-05 12:09:27 +08:00
parent 3977925e8a
commit e592a09ec3
3 changed files with 15 additions and 3 deletions

View File

@ -23,7 +23,9 @@ abstract class ReorderFlexDragTargetInterceptor {
ReorderFlexDraggableTargetBuilder? get draggableTargetBuilder => null;
}
abstract class OverlapReorderFlexDragTargetDelegate {}
abstract class OverlapReorderFlexDragTargetDelegate {
void dragTargetDidDisappear();
}
class OverlapReorderFlexDragTargetInteceptor
extends ReorderFlexDragTargetInterceptor {
@ -50,7 +52,7 @@ class OverlapReorderFlexDragTargetInteceptor
required String dragTargetId,
required int dragTargetIndex}) {
if (dragTargetId == dragTargetData.reorderFlexId) {
Log.debug('remove all phantom');
delegate.dragTargetDidDisappear();
} else {
Log.debug('add phantom to $dragTargetId');
}

View File

@ -396,7 +396,7 @@ class ReorderFlexState extends State<ReorderFlex>
/// The [willAccept] will be true if the dargTarget is the widget that gets
/// dragged and it is dragged on top of the other dragTargets.
///
Log.debug(
Log.trace(
'[$ReorderDragTarget] ${widget.dataSource.identifier} on will accept, dragIndex:$dragIndex, dragTargetIndex:$dragTargetIndex, count: ${widget.dataSource.items.length}');
bool willAccept =

View File

@ -207,6 +207,16 @@ class BoardPhantomController extends OverlapReorderFlexDragTargetDelegate
_updatePhantom(phantomRecord!.toColumnId, dragTargetIndex);
}
}
@override
void dragTargetDidDisappear() {
if (phantomRecord == null) {
return;
}
_removePhantom(phantomRecord!.toColumnId);
phantomRecord = null;
}
}
/// Use [PhantomRecord] to record where to remove the column item and where to