Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: await the cell dispose (#1437)

Browse Source
This commit is contained in:
Nathan.fooo 2022-11-11 12:41:53 +08:00 committed by GitHub
parent 840095d73c
commit f426745094
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
16 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/app_flowy/lib/plugins/board/application/card/board_checkbox_cell_bloc.dart
View File

@ -35,7 +35,7 @@ class BoardCheckboxCellBloc
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/board/application/card/board_date_cell_bloc.dart
View File

@ -31,7 +31,7 @@ class BoardDateCellBloc extends Bloc<BoardDateCellEvent, BoardDateCellState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/board/application/card/board_number_cell_bloc.dart
View File

@ -32,7 +32,7 @@ class BoardNumberCellBloc
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/board/application/card/board_select_option_cell_bloc.dart
View File

@ -34,7 +34,7 @@ class BoardSelectOptionCellBloc
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/board/application/card/board_text_cell_bloc.dart
View File

@ -41,7 +41,7 @@ class BoardTextCellBloc extends Bloc<BoardTextCellEvent, BoardTextCellState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/board/application/card/board_url_cell_bloc.dart
View File

@ -38,7 +38,7 @@ class BoardURLCellBloc extends Bloc<BoardURLCellEvent, BoardURLCellState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

6
frontend/app_flowy/lib/plugins/grid/application/cell/cell_service/cell_controller.dart
View File

@ -290,20 +290,20 @@ class IGridCellController<T, D> extends Equatable {
}); });
} }
void dispose() { Future<void> dispose() async {
if (_isDispose) { if (_isDispose) {
Log.error("$this should only dispose once"); Log.error("$this should only dispose once");
return; return;
} }
_isDispose = true; _isDispose = true;
_cellListener?.stop(); await _cellListener?.stop();
_loadDataOperation?.cancel(); _loadDataOperation?.cancel();
_saveDataOperation?.cancel(); _saveDataOperation?.cancel();
_cellDataNotifier = null; _cellDataNotifier = null;
if (_onFieldChangedFn != null) { if (_onFieldChangedFn != null) {
_fieldNotifier.unregister(_cacheKey, _onFieldChangedFn!); _fieldNotifier.unregister(_cacheKey, _onFieldChangedFn!);
_fieldNotifier.dispose(); await _fieldNotifier.dispose();
_onFieldChangedFn = null; _onFieldChangedFn = null;
} }
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/checkbox_cell_bloc.dart
View File

@ -37,7 +37,7 @@ class CheckboxCellBloc extends Bloc<CheckboxCellEvent, CheckboxCellState> {
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/date_cal_bloc.dart
View File

@ -139,7 +139,7 @@ class DateCalBloc extends Bloc<DateCalEvent, DateCalState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/date_cell_bloc.dart
View File

@ -31,7 +31,7 @@ class DateCellBloc extends Bloc<DateCellEvent, DateCellState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/number_cell_bloc.dart
View File

@ -46,7 +46,7 @@ class NumberCellBloc extends Bloc<NumberCellEvent, NumberCellState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/select_option_cell_bloc.dart
View File

@ -36,7 +36,7 @@ class SelectOptionCellBloc
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart
View File

@ -81,7 +81,7 @@ class SelectOptionCellEditorBloc
@override @override
Future<void> close() async { Future<void> close() async {
_delayOperation?.cancel(); _delayOperation?.cancel();
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/text_cell_bloc.dart
View File

@ -35,7 +35,7 @@ class TextCellBloc extends Bloc<TextCellEvent, TextCellState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/url_cell_bloc.dart
View File

@ -38,7 +38,7 @@ class URLCellBloc extends Bloc<URLCellEvent, URLCellState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }

2
frontend/app_flowy/lib/plugins/grid/application/cell/url_cell_editor_bloc.dart
View File

@ -36,7 +36,7 @@ class URLCellEditorBloc extends Bloc<URLCellEditorEvent, URLCellEditorState> {
cellController.removeListener(_onCellChangedFn!); cellController.removeListener(_onCellChangedFn!);
_onCellChangedFn = null; _onCellChangedFn = null;
} }
cellController.dispose(); await cellController.dispose();
return super.close(); return super.close();
} }