From fad02eb09d95ef06e159f1bf0af6b66799fea416 Mon Sep 17 00:00:00 2001
From: Cyrine-benabid <cyrine.ben-abid@deepomatic.com>
Date: Sun, 30 Oct 2022 20:19:20 +0100
Subject: [PATCH] fix: remove useless onTap

---
 .../grid/presentation/widgets/common/text_field.dart       | 7 -------
 .../widgets/header/type_option/select_option.dart          | 1 -
 .../flowy_infra_ui/lib/widget/rounded_input_field.dart     | 7 -------
 3 files changed, 15 deletions(-)

diff --git a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart
index bc28298f17..cbb28ae1c7 100644
--- a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart
+++ b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart
@@ -9,7 +9,6 @@ class InputTextField extends StatefulWidget {
   final void Function(String)? onDone;
   final void Function(String)? onChanged;
   final void Function() onCanceled;
-  final void Function()? onTap;
   final bool autoClearWhenDone;
   final String text;
   final int? maxLength;
@@ -20,7 +19,6 @@ class InputTextField extends StatefulWidget {
     this.onDone,
     required this.onCanceled,
     this.onChanged,
-    this.onTap,
     this.autoClearWhenDone = false,
     this.maxLength,
     this.focusNode,
@@ -75,11 +73,6 @@ class _InputTextFieldState extends State<InputTextField> {
           _controller.text = "";
         }
       },
-      onTap: () {
-        if (widget.onTap != null) {
-          widget.onTap!();
-        }
-      },
     );
   }
 
diff --git a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart
index 36a200454b..0deba533de 100644
--- a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart
+++ b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart
@@ -256,7 +256,6 @@ class _AddOptionButton extends StatelessWidget {
             fontSize: 12),
         hoverColor: theme.hover,
         onTap: () {
-          popoverMutex?.close();
           context
               .read<SelectOptionTypeOptionBloc>()
               .add(const SelectOptionTypeOptionEvent.addingOption());
diff --git a/frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart b/frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart
index becdfd8b06..9dec787c2e 100644
--- a/frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart
+++ b/frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart
@@ -19,7 +19,6 @@ class RoundedInputField extends StatefulWidget {
   final TextStyle style;
   final ValueChanged<String>? onChanged;
   final Function(String)? onEditingComplete;
-  final Function()? onTap;
   final String? initialValue;
   final EdgeInsets margin;
   final EdgeInsets padding;
@@ -40,7 +39,6 @@ class RoundedInputField extends StatefulWidget {
     this.obscureHideIcon,
     this.onChanged,
     this.onEditingComplete,
-    this.onTap,
     this.normalBorderColor = Colors.transparent,
     this.errorBorderColor = Colors.transparent,
     this.focusBorderColor,
@@ -111,11 +109,6 @@ class _RoundedInputFieldState extends State<RoundedInputField> {
               widget.onEditingComplete!(inputText);
             }
           },
-          onTap: () {
-            if (widget.onTap != null) {
-              widget.onTap!();
-            }
-          },
           cursorColor: widget.cursorColor,
           obscureText: obscuteText,
           style: widget.style,