From 09af7d964dec7f107a6924a2a542dfb91aae6a3d Mon Sep 17 00:00:00 2001
From: Matthias <code@mjmair.com>
Date: Tue, 17 May 2022 00:24:02 +0200
Subject: [PATCH] raise a warning for assertations

---
 InvenTree/InvenTree/tasks.py      | 21 ++++++++++++++++-----
 InvenTree/InvenTree/test_tasks.py | 11 ++++++++---
 2 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/InvenTree/InvenTree/tasks.py b/InvenTree/InvenTree/tasks.py
index 6dc8b7d297..a750c393e6 100644
--- a/InvenTree/InvenTree/tasks.py
+++ b/InvenTree/InvenTree/tasks.py
@@ -3,6 +3,7 @@ from __future__ import unicode_literals
 
 import re
 import json
+import warnings
 import requests
 import logging
 
@@ -12,6 +13,7 @@ from django.utils import timezone
 from django.core.exceptions import AppRegistryNotReady
 from django.db.utils import OperationalError, ProgrammingError
 from django.core import mail as django_mail
+from django.conf import settings
 
 
 logger = logging.getLogger("inventree")
@@ -53,6 +55,15 @@ def schedule_task(taskname, **kwargs):
         pass
 
 
+def raise_warning(msg):
+    """Log and raise a warning"""
+    logger.warning(msg)
+
+    # If testing is running raise a warning that can be asserted
+    if settings.TESTING:
+        warnings.warn(msg)
+
+
 def offload_task(taskname, *args, force_sync=False, **kwargs):
     """
         Create an AsyncTask if workers are running.
@@ -72,7 +83,7 @@ def offload_task(taskname, *args, force_sync=False, **kwargs):
         logger.warning(f"Could not offload task '{taskname}' - app registry not ready")
         return
     except (OperationalError, ProgrammingError):  # pragma: no cover
-        logger.warning(f"Could not offload task '{taskname}' - database not ready")
+        raise_warning(f"Could not offload task '{taskname}' - database not ready")
 
     if is_worker_running() and not force_sync:  # pragma: no cover
         # Running as asynchronous task
@@ -80,7 +91,7 @@ def offload_task(taskname, *args, force_sync=False, **kwargs):
             task = AsyncTask(taskname, *args, **kwargs)
             task.run()
         except ImportError:
-            logger.warning(f"WARNING: '{taskname}' not started - Function not found")
+            raise_warning(f"WARNING: '{taskname}' not started - Function not found")
     else:
 
         if callable(taskname):
@@ -92,14 +103,14 @@ def offload_task(taskname, *args, force_sync=False, **kwargs):
                 app, mod, func = taskname.split('.')
                 app_mod = app + '.' + mod
             except ValueError:
-                logger.warning(f"WARNING: '{taskname}' not started - Malformed function path")
+                raise_warning(f"WARNING: '{taskname}' not started - Malformed function path")
                 return
 
             # Import module from app
             try:
                 _mod = importlib.import_module(app_mod)
             except ModuleNotFoundError:
-                logger.warning(f"WARNING: '{taskname}' not started - No module named '{app_mod}'")
+                raise_warning(f"WARNING: '{taskname}' not started - No module named '{app_mod}'")
                 return
 
             # Retrieve function
@@ -113,7 +124,7 @@ def offload_task(taskname, *args, force_sync=False, **kwargs):
                 if not _func:
                     _func = eval(func)  # pragma: no cover
             except NameError:
-                logger.warning(f"WARNING: '{taskname}' not started - No function named '{func}'")
+                raise_warning(f"WARNING: '{taskname}' not started - No function named '{func}'")
                 return
 
         # Workers are not running: run it as synchronous task
diff --git a/InvenTree/InvenTree/test_tasks.py b/InvenTree/InvenTree/test_tasks.py
index 1502037dba..eb307f2292 100644
--- a/InvenTree/InvenTree/test_tasks.py
+++ b/InvenTree/InvenTree/test_tasks.py
@@ -72,11 +72,16 @@ class InvenTreeTaskTests(TestCase):
 
         # Error runs
         # Malformed taskname
-        InvenTree.tasks.offload_task('InvenTree')
+        with self.assertWarnsMessage(UserWarning, "WARNING: 'InvenTree' not started - Malformed function path"):
+            InvenTree.tasks.offload_task('InvenTree')
+
         # Non exsistent app
-        InvenTree.tasks.offload_task('InvenTreeABC.test_tasks.doesnotmatter')
+        with self.assertWarnsMessage(UserWarning, "WARNING: 'InvenTreeABC.test_tasks.doesnotmatter' not started - No module named 'InvenTreeABC'"):
+            InvenTree.tasks.offload_task('InvenTreeABC.test_tasks.doesnotmatter')
+
         # Non exsistent function
-        InvenTree.tasks.offload_task('InvenTree.test_tasks.doesnotexsist')
+        with self.assertWarnsMessage(UserWarning, "WARNING: 'InvenTree.test_tasks.doesnotexsist' not started - No function named 'doesnotexsist'"):
+            InvenTree.tasks.offload_task('InvenTree.test_tasks.doesnotexsist')
 
     def test_task_hearbeat(self):
         """Test the task heartbeat"""