Mirrored_Repos/InvenTree
1
0
Fork 0
mirror of https://github.com/inventree/InvenTree synced 2024-08-30 18:33:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor clean method to reduce duplication

Browse Source
This commit is contained in:
Matthias 2022-04-05 00:14:39 +02:00
parent 8d01df0b5e
commit 205916e0b2
No known key found for this signature in database
GPG Key ID: F50EF5741D33E076
1 changed files with 11 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
InvenTree/plugin/models.py
View File

@ -112,6 +112,17 @@ class GenericSettingClassMixin:
self.REFERENCE_NAME: getattr(self, self.REFERENCE_NAME) self.REFERENCE_NAME: getattr(self, self.REFERENCE_NAME)
} }
"""
We override the following class methods,
so that we can pass the modified key instance as an additional argument
"""
def clean(self, **kwargs):
kwargs[self.REFERENCE_NAME] = getattr(self, self.REFERENCE_NAME)
super().clean(**kwargs)
def is_bool(self, **kwargs): def is_bool(self, **kwargs):
kwargs[self.REFERENCE_NAME] = getattr(self, self.REFERENCE_NAME) kwargs[self.REFERENCE_NAME] = getattr(self, self.REFERENCE_NAME)
@ -148,17 +159,6 @@ class PluginSetting(GenericSettingClassMixin, common.models.BaseInvenTreeSetting
('plugin', 'key'), ('plugin', 'key'),
] ]
def clean(self, **kwargs):
kwargs['plugin'] = self.plugin
super().clean(**kwargs)
"""
We override the following class methods,
so that we can pass the plugin instance
"""
REFERENCE_NAME = 'plugin' REFERENCE_NAME = 'plugin'
@classmethod @classmethod
@ -208,17 +208,6 @@ class NotificationUserSetting(common.models.BaseInvenTreeSetting):
('method', 'user', 'key'), ('method', 'user', 'key'),
] ]
def clean(self, **kwargs):
kwargs['method'] = self.method
super().clean(**kwargs)
"""
We override the following class methods,
so that we can pass the method instance
"""
REFERENCE_NAME = 'method' REFERENCE_NAME = 'method'
@classmethod @classmethod