From 36e6b9f164b5f6980c60ace3717afbd80d24e23f Mon Sep 17 00:00:00 2001 From: Oliver Date: Wed, 23 Jun 2021 11:40:37 +1000 Subject: [PATCH] Set allow_null flag on image fields --- InvenTree/company/serializers.py | 2 +- InvenTree/company/test_api.py | 9 +++++++-- InvenTree/part/serializers.py | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/InvenTree/company/serializers.py b/InvenTree/company/serializers.py index 11daf8898b..1e97756987 100644 --- a/InvenTree/company/serializers.py +++ b/InvenTree/company/serializers.py @@ -53,7 +53,7 @@ class CompanySerializer(InvenTreeModelSerializer): url = serializers.CharField(source='get_absolute_url', read_only=True) - image = InvenTreeImageSerializerField(required=False) + image = InvenTreeImageSerializerField(required=False, allow_null=True) parts_supplied = serializers.IntegerField(read_only=True) parts_manufactured = serializers.IntegerField(read_only=True) diff --git a/InvenTree/company/test_api.py b/InvenTree/company/test_api.py index d5cb573f47..dd42b97801 100644 --- a/InvenTree/company/test_api.py +++ b/InvenTree/company/test_api.py @@ -50,10 +50,15 @@ class CompanyTest(InvenTreeAPITestCase): self.assertEqual(response.data['name'], 'ACME') # Change the name of the company + # Note we should not have the correct permissions (yet) data = response.data data['name'] = 'ACMOO' - response = self.client.patch(url, data, format='json') - self.assertEqual(response.status_code, status.HTTP_200_OK) + response = self.client.patch(url, data, format='json', expected_code=400) + + self.assignRole('company.change') + + response = self.client.patch(url, data, format='json', expected_code=200) + self.assertEqual(response.data['name'], 'ACMOO') def test_company_search(self): diff --git a/InvenTree/part/serializers.py b/InvenTree/part/serializers.py index fe0ceea560..6c47f1310f 100644 --- a/InvenTree/part/serializers.py +++ b/InvenTree/part/serializers.py @@ -303,7 +303,7 @@ class PartSerializer(InvenTreeModelSerializer): stock_item_count = serializers.IntegerField(read_only=True) suppliers = serializers.IntegerField(read_only=True) - image = InvenTreeImageSerializerField(required=False) + image = InvenTreeImageSerializerField(required=False, allow_null=True) thumbnail = serializers.CharField(source='get_thumbnail_url', read_only=True) starred = serializers.SerializerMethodField()