Mirrored_Repos/InvenTree
1
0
Fork 0
mirror of https://github.com/inventree/InvenTree synced 2024-08-30 18:33:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for custom SQL queries

Browse Source 
- Don't use double quotes!
- NO NO NO!
- Single quotes only
This commit is contained in:
Oliver Walters 2020-11-19 09:15:16 +11:00
parent 0594ebaef7
commit 599220a931
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
InvenTree/company/migrations/0026_auto_20201110_1011.py
View File

@ -67,7 +67,7 @@ def migrate_currencies(apps, schema_editor):
currency_code = remap.get(currency_id, 'USD') currency_code = remap.get(currency_id, 'USD')
# Update the currency code # Update the currency code
response = cursor.execute(f'UPDATE part_supplierpricebreak set price_currency= "{currency_code}" where id={pk};') response = cursor.execute(f"UPDATE part_supplierpricebreak set price_currency= '{currency_code}' where id={pk};")
count += 1 count += 1
@ -105,7 +105,7 @@ def reverse_currencies(apps, schema_editor):
# For each currency code in use, check if we have a matching Currency object # For each currency code in use, check if we have a matching Currency object
for code in codes_in_use: for code in codes_in_use:
response = cursor.execute(f'SELECT id, suffix from common_currency where suffix="{code}";') response = cursor.execute(f"SELECT id, suffix from common_currency where suffix='{code}';")
row = response.fetchone() row = response.fetchone()
if row is not None: if row is not None:
@ -133,7 +133,7 @@ def reverse_currencies(apps, schema_editor):
# Update the table to point to the Currency objects # Update the table to point to the Currency objects
print(f"Currency {suffix} -> pk {pk}") print(f"Currency {suffix} -> pk {pk}")
response = cursor.execute(f'UPDATE part_supplierpricebreak set currency_id={pk} where price_currency="{suffix}";') response = cursor.execute(f"UPDATE part_supplierpricebreak set currency_id={pk} where price_currency='{suffix}';")
class Migration(migrations.Migration): class Migration(migrations.Migration):

8
InvenTree/part/migrations/0056_auto_20201110_1125.py
View File

@ -67,7 +67,7 @@ def migrate_currencies(apps, schema_editor):
currency_code = remap.get(currency_id, 'USD') currency_code = remap.get(currency_id, 'USD')
# Update the currency code # Update the currency code
response = cursor.execute(f'UPDATE part_partsellpricebreak set price_currency= "{currency_code}" where id={pk};') response = cursor.execute(f"UPDATE part_partsellpricebreak set price_currency='{currency_code}' where id={pk};")
count += 1 count += 1
@ -105,7 +105,7 @@ def reverse_currencies(apps, schema_editor):
# For each currency code in use, check if we have a matching Currency object # For each currency code in use, check if we have a matching Currency object
for code in codes_in_use: for code in codes_in_use:
response = cursor.execute(f'SELECT id, suffix from common_currency where suffix="{code}";') response = cursor.execute(f"SELECT id, suffix from common_currency where suffix='{code}';")
row = response.fetchone() row = response.fetchone()
if row is not None: if row is not None:
@ -120,7 +120,7 @@ def reverse_currencies(apps, schema_editor):
print(f"Creating new Currency object for {code}") print(f"Creating new Currency object for {code}")
# Construct a query to create a new Currency object # Construct a query to create a new Currency object
query = f'INSERT into common_currency (symbol, suffix, description, value, base) VALUES ("$", "{code}", "{description}", 1.0, False);' query = f"INSERT into common_currency (symbol, suffix, description, value, base) VALUES ('$', '{code}', '{description}', 1.0, False);"
response = cursor.execute(query) response = cursor.execute(query)
@ -133,7 +133,7 @@ def reverse_currencies(apps, schema_editor):
# Update the table to point to the Currency objects # Update the table to point to the Currency objects
print(f"Currency {suffix} -> pk {pk}") print(f"Currency {suffix} -> pk {pk}")
response = cursor.execute(f'UPDATE part_partsellpricebreak set currency_id={pk} where price_currency="{suffix}";') response = cursor.execute(f"UPDATE part_partsellpricebreak set currency_id={pk} where price_currency='{suffix}';")
class Migration(migrations.Migration): class Migration(migrations.Migration):