From 6fcc9ec8f06b4339bb6ed41f455a0002be10d2b3 Mon Sep 17 00:00:00 2001 From: Oliver Date: Mon, 7 Mar 2022 15:01:15 +1100 Subject: [PATCH] Unit test fixes --- InvenTree/stock/models.py | 2 +- InvenTree/stock/tests.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/InvenTree/stock/models.py b/InvenTree/stock/models.py index 69d2bbaf26..27d6cf5fc3 100644 --- a/InvenTree/stock/models.py +++ b/InvenTree/stock/models.py @@ -272,7 +272,7 @@ class StockItem(MPTTModel): serial = str(serial).strip() - serial_int = extract_int(str(serial)) + serial_int = extract_int(serial) self.serial_int = serial_int diff --git a/InvenTree/stock/tests.py b/InvenTree/stock/tests.py index 0ee17b244a..d1e68fc8e5 100644 --- a/InvenTree/stock/tests.py +++ b/InvenTree/stock/tests.py @@ -405,15 +405,15 @@ class StockTest(TestCase): item.serial = "-123" item.save() + # Negative number should map to zero + self.assertEqual(item.serial_int, 0) + # Test a very very large value item.serial = '99999999999999999999999999999999999999999999999999999' item.save() self.assertEqual(item.serial_int, 0x7fffffff) - # Negative number should map to zero - self.assertEqual(item.serial_int, 0) - # Non-numeric values should encode to zero for sn in ['apple', 'banana', 'carrot']: item.serial = sn