stop cascade update_pricing if prices didnt change (#5606) (#5607)

Co-authored-by: Oliver Lippert <oliver@lipperts-web.de>
(cherry picked from commit 2f0dbf9776)

Co-authored-by: Oliver Lippert <oliver@allesit.de>
This commit is contained in:
github-actions[bot] 2023-09-24 23:06:03 +10:00 committed by GitHub
parent 85b8157611
commit 978e08f3a3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -2346,6 +2346,8 @@ class PartPricing(common.models.MetaMixin):
- Detailed pricing information is very context specific in any case
"""
price_modified = False
@property
def is_valid(self):
"""Return True if the cached pricing is valid"""
@ -2472,7 +2474,7 @@ class PartPricing(common.models.MetaMixin):
pass
# Update parent assemblies and templates
if cascade:
if cascade and self.price_modified:
self.update_assemblies(counter)
self.update_templates(counter)
@ -2572,6 +2574,9 @@ class PartPricing(common.models.MetaMixin):
any_max_elements = True
old_bom_cost_min = self.bom_cost_min
old_bom_cost_max = self.bom_cost_max
if any_min_elements:
self.bom_cost_min = cumulative_min
else:
@ -2582,6 +2587,9 @@ class PartPricing(common.models.MetaMixin):
else:
self.bom_cost_max = None
if old_bom_cost_min != self.bom_cost_min or old_bom_cost_max != self.bom_cost_max:
self.price_modified = True
if save:
self.save()
@ -2646,6 +2654,9 @@ class PartPricing(common.models.MetaMixin):
if purchase_max is None or cost > purchase_max:
purchase_max = cost
if self.purchase_cost_min != purchase_min or self.purchase_cost_max != purchase_max:
self.price_modified = True
self.purchase_cost_min = purchase_min
self.purchase_cost_max = purchase_max
@ -2673,6 +2684,9 @@ class PartPricing(common.models.MetaMixin):
if max_int_cost is None or cost > max_int_cost:
max_int_cost = cost
if self.internal_cost_min != min_int_cost or self.internal_cost_max != max_int_cost:
self.price_modified = True
self.internal_cost_min = min_int_cost
self.internal_cost_max = max_int_cost
@ -2712,6 +2726,9 @@ class PartPricing(common.models.MetaMixin):
if max_sup_cost is None or cost > max_sup_cost:
max_sup_cost = cost
if self.supplier_price_min != min_sup_cost or self.supplier_price_max != max_sup_cost:
self.price_modified = True
self.supplier_price_min = min_sup_cost
self.supplier_price_max = max_sup_cost
@ -2749,6 +2766,9 @@ class PartPricing(common.models.MetaMixin):
if variant_max is None or v_max > variant_max:
variant_max = v_max
if self.variant_cost_min != variant_min or self.variant_cost_max != variant_max:
self.price_modified = True
self.variant_cost_min = variant_min
self.variant_cost_max = variant_max
@ -2873,6 +2893,9 @@ class PartPricing(common.models.MetaMixin):
if max_sell_history is None or cost > max_sell_history:
max_sell_history = cost
if self.sale_history_min != min_sell_history or self.sale_history_max != max_sell_history:
self.price_modified = True
self.sale_history_min = min_sell_history
self.sale_history_max = max_sell_history