Mirrored_Repos/InvenTree
1
0
Fork 0
mirror of https://github.com/inventree/InvenTree synced 2024-08-30 18:33:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Increase unit testing for duplicate IPN testing

Browse Source 
- IPN duplication test is case sensitive!
This commit is contained in:
Oliver Walters 2022-04-22 00:38:08 +10:00
parent 9a9ed5f192
commit a7c18891b5
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
InvenTree/part/models.py
View File

@ -779,7 +779,7 @@ class Part(MPTTModel):
# Raise an error if an IPN is set, and it is a duplicate # Raise an error if an IPN is set, and it is a duplicate
if self.IPN and not allow_duplicate_ipn: if self.IPN and not allow_duplicate_ipn:
parts = Part.objects.filter(IPN__iexact=self.IPN) parts = Part.objects.filter(IPN=self.IPN)
parts = parts.exclude(pk=self.pk) parts = parts.exclude(pk=self.pk)
if parts.exists(): if parts.exists():

20
InvenTree/part/test_part.py
View File

@ -349,6 +349,26 @@ class PartSettingsTest(TestCase):
part = Part(name='Hello', description='A thing', IPN='IPN123', revision='C') part = Part(name='Hello', description='A thing', IPN='IPN123', revision='C')
part.full_clean() part.full_clean()
# Any duplicate IPN should raise an error
Part.objects.create(name='xyz', revision='1', description='A part', IPN='UNIQUE')
# Case sensitive, so other variations don't error out:
Part.objects.create(name='xyz', revision='2', description='A part', IPN='UNIQUe')
Part.objects.create(name='xyz', revision='3', description='A part', IPN='UNIQuE')
Part.objects.create(name='xyz', revision='4', description='A part', IPN='UNIqUE')
with self.assertRaises(ValidationError):
Part.objects.create(name='zyx', description='A part', IPN='UNIQUE')
# However, *blank* / empty IPN values should be allowed, even if duplicates are not
# Note that leading / trailling whitespace characters are trimmed, too
Part.objects.create(name='abc', revision='1', description='A part', IPN=None)
Part.objects.create(name='abc', revision='2', description='A part', IPN='')
Part.objects.create(name='abc', revision='3', description='A part', IPN=None)
Part.objects.create(name='abc', revision='4', description='A part', IPN=' ')
Part.objects.create(name='abc', revision='5', description='A part', IPN=' ')
Part.objects.create(name='abc', revision='6', description='A part', IPN=' ')
class PartSubscriptionTests(TestCase): class PartSubscriptionTests(TestCase):