Unit test fixes

This commit is contained in:
Oliver Walters
2021-04-21 17:16:07 +10:00
parent 59341397ba
commit c0ab2d1da9
18 changed files with 2671 additions and 2123 deletions

View File

@ -449,6 +449,9 @@ class BuildOutputComplete(AjaxUpdateView):
return form
def validate(self, build, form, **kwargs):
"""
Custom validation steps for the BuildOutputComplete" form
"""
data = form.cleaned_data
@ -456,8 +459,14 @@ class BuildOutputComplete(AjaxUpdateView):
stock_status = data.get('stock_status', StockStatus.OK)
# Any "invalid" stock status defaults to OK
try:
stock_status = int(stock_status)
except (ValueError):
stock_status = StockStatus.OK
if int(stock_status) not in StockStatus.keys():
form.add_error('status', _('Invalid stock status value selected'))
form.add_error('stock_status', _('Invalid stock status value selected'))
if output:
@ -552,6 +561,12 @@ class BuildOutputComplete(AjaxUpdateView):
output = data.get('output', None)
stock_status = data.get('stock_status', StockStatus.OK)
# Any "invalid" stock status defaults to OK
try:
stock_status = int(stock_status)
except (ValueError):
stock_status = StockStatus.OK
# Complete the build output
build.completeBuildOutput(
output,