From d111e7bff028deabe8e214362846a4aaf5a455f5 Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Thu, 4 Mar 2021 21:42:49 +1100 Subject: [PATCH 1/3] Hide fields rather than pop, to reduce warnings in CI logs --- InvenTree/part/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/InvenTree/part/views.py b/InvenTree/part/views.py index 1cb2976ff8..65f859566b 100644 --- a/InvenTree/part/views.py +++ b/InvenTree/part/views.py @@ -613,7 +613,7 @@ class PartCreate(AjaxCreateView): # Hide the "default expiry" field if the feature is not enabled if not inventree_settings.stock_expiry_enabled(): - form.fields.pop('default_expiry') + form.fields['default_expiry'].widget = HiddenInput() # Hide the default_supplier field (there are no matching supplier parts yet!) form.fields['default_supplier'].widget = HiddenInput() @@ -904,7 +904,7 @@ class PartEdit(AjaxUpdateView): # Hide the "default expiry" field if the feature is not enabled if not inventree_settings.stock_expiry_enabled(): - form.fields.pop('default_expiry') + form.fields['default_expiry'].widget = HiddenInput() part = self.get_object() From 5ad915a8453d4f2ef351680e6a1158b9090ea45f Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Thu, 4 Mar 2021 22:09:46 +1100 Subject: [PATCH 2/3] More fields --- InvenTree/stock/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/InvenTree/stock/views.py b/InvenTree/stock/views.py index 913ea598b3..7661949d19 100644 --- a/InvenTree/stock/views.py +++ b/InvenTree/stock/views.py @@ -1232,7 +1232,7 @@ class StockItemEdit(AjaxUpdateView): # Hide the "expiry date" field if the feature is not enabled if not common.settings.stock_expiry_enabled(): - form.fields.pop('expiry_date') + self.fields['expiry_date'].widget = HiddenInput() item = self.get_object() @@ -1581,7 +1581,7 @@ class StockItemCreate(AjaxCreateView): # Hide the "expiry date" field if the feature is not enabled if not common.settings.stock_expiry_enabled(): - form.fields.pop('expiry_date') + self.fields['expiry_date'].widget = HiddenInput() part = self.get_part(form=form) From d43cfccfc1e85da9478e7aca15eaaec6fdf35f5f Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Thu, 4 Mar 2021 22:11:38 +1100 Subject: [PATCH 3/3] Typo fix --- InvenTree/stock/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/InvenTree/stock/views.py b/InvenTree/stock/views.py index 7661949d19..6edcb8cf70 100644 --- a/InvenTree/stock/views.py +++ b/InvenTree/stock/views.py @@ -1232,7 +1232,7 @@ class StockItemEdit(AjaxUpdateView): # Hide the "expiry date" field if the feature is not enabled if not common.settings.stock_expiry_enabled(): - self.fields['expiry_date'].widget = HiddenInput() + form.fields['expiry_date'].widget = HiddenInput() item = self.get_object() @@ -1581,7 +1581,7 @@ class StockItemCreate(AjaxCreateView): # Hide the "expiry date" field if the feature is not enabled if not common.settings.stock_expiry_enabled(): - self.fields['expiry_date'].widget = HiddenInput() + form.fields['expiry_date'].widget = HiddenInput() part = self.get_part(form=form)