From c5efce36b6ab6110c9dd63b3f2e99ce4d32fb113 Mon Sep 17 00:00:00 2001 From: eeintech Date: Mon, 7 Sep 2020 08:40:37 -0500 Subject: [PATCH] Added PartDetailFromIPN view tests --- InvenTree/InvenTree/ci_postgresql.py | 2 +- InvenTree/part/test_views.py | 50 ++++++++++++++++++++++++++++ InvenTree/part/views.py | 2 ++ 3 files changed, 53 insertions(+), 1 deletion(-) diff --git a/InvenTree/InvenTree/ci_postgresql.py b/InvenTree/InvenTree/ci_postgresql.py index ba9aa26bb1..67bb24540f 100644 --- a/InvenTree/InvenTree/ci_postgresql.py +++ b/InvenTree/InvenTree/ci_postgresql.py @@ -6,7 +6,7 @@ from InvenTree.settings import * # Override the 'test' database if 'test' in sys.argv: - eprint('InvenTree: Running tests - Using MySQL test database') + eprint('InvenTree: Running tests - Using PostGreSQL test database') DATABASES['default'] = { # Ensure postgresql backend is being used diff --git a/InvenTree/part/test_views.py b/InvenTree/part/test_views.py index 16711c78f6..43ba373e58 100644 --- a/InvenTree/part/test_views.py +++ b/InvenTree/part/test_views.py @@ -78,6 +78,56 @@ class PartDetailTest(PartViewTestCase): self.assertEqual(response.status_code, 200) self.assertTrue(response.context['editing_enabled']) + def test_part_detail_from_ipn(self): + """ + Test that we can retrieve a part detail page from part IPN: + - if no part with matching IPN -> return part index + - if unique IPN match -> return part detail page + - if multiple IPN matches -> return part index + """ + ipn_test = 'PART-000000-AA' + pk = 1 + + def test_ipn_match(index_result=False, detail_result=False): + index_redirect = False + detail_redirect = False + + response = self.client.get(reverse('part-detail-from-ipn', args=(ipn_test,))) + + # Check for PartIndex redirect + try: + if response.url == '/part/': + index_redirect = True + except AttributeError: + pass + + # Check for PartDetail redirect + try: + if response.context['part'].pk == pk: + detail_redirect = True + except TypeError: + pass + + self.assertEqual(index_result, index_redirect) + self.assertEqual(detail_result, detail_redirect) + + # Test no match + test_ipn_match(index_result=True, detail_result=False) + + # Test unique match + part = Part.objects.get(pk=pk) + part.IPN = ipn_test + part.save() + + test_ipn_match(index_result=False, detail_result=True) + + # Test multiple matches + part = Part.objects.get(pk=pk+1) + part.IPN = ipn_test + part.save() + + test_ipn_match(index_result=True, detail_result=False) + def test_bom_download(self): """ Test downloading a BOM for a valid part """ diff --git a/InvenTree/part/views.py b/InvenTree/part/views.py index ef5c7a41a2..58ece9d0b0 100644 --- a/InvenTree/part/views.py +++ b/InvenTree/part/views.py @@ -683,6 +683,8 @@ class PartDetailFromIPN(PartDetail): part = queryset.get() # Return Part object return part + except queryset.model.MultipleObjectsReturned: + pass except queryset.model.DoesNotExist: pass