Mirrored_Repos/InvenTree
1
0
Fork 0
mirror of https://github.com/inventree/InvenTree synced 2024-08-30 18:33:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1123 from eeintech/fix_form_errors

Browse Source 
Fixed disabling of form errors messing-up with global settings validation
This commit is contained in:
Oliver 2020-11-13 09:59:57 +11:00 committed by GitHub
commit d777549a1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
InvenTree/InvenTree/forms.py
View File

@ -29,11 +29,6 @@ class HelperForm(forms.ModelForm):
self.helper.form_tag = False self.helper.form_tag = False
# Check for errors from model validation
# If none, disable crispy form errors
if not self.errors:
self.helper.form_show_errors = False
""" """
Create a default 'layout' for this form. Create a default 'layout' for this form.
Ref: https://django-crispy-forms.readthedocs.io/en/latest/layouts.html Ref: https://django-crispy-forms.readthedocs.io/en/latest/layouts.html
@ -44,6 +39,17 @@ class HelperForm(forms.ModelForm):
self.rebuild_layout() self.rebuild_layout()
def is_valid(self):
valid = super(HelperForm, self).is_valid()
# Check for errors from model validation
# If none, disable crispy form errors
if not self.errors:
self.helper.form_show_errors = False
return valid
def rebuild_layout(self): def rebuild_layout(self):
layouts = [] layouts = []