Simplified custom button text for modal forms

- Now only configured from the javascript end
- No server-side configuration of button text

InvenTree/InvenTree/views.py

@@ -56,7 +56,6 @@ class AjaxMixin(object):
 
     ajax_form_action = ''
     ajax_form_title = ''
-    ajax_submit_text = 'Submit'
 
     def get_data(self):
         return {}
@@ -76,8 +75,6 @@ class AjaxMixin(object):
 
         data['title'] = self.ajax_form_title
 
-        data['submit_label'] = self.ajax_submit_text
-
         data['html_form'] = render_to_string(
             self.getAjaxTemplate(),
             context,

InvenTree/build/templates/build/detail.html

@@ -109,7 +109,8 @@
     $("#build-cancel").click(function() {
         launchModalForm("{% url 'build-cancel' build.id %}",
                         {
-                            reload: true
+                            reload: true,
+                            submit_text: "Cancel",
                         });
     });
 {% endblock %}

InvenTree/build/views.py

@@ -40,7 +40,6 @@ class BuildCancel(AjaxView):
     model = Build
     template_name = 'build/cancel.html'
     ajax_form_title = 'Cancel Build'
-    ajax_submit_text = 'Cancel'
     context_object_name = 'build'
     fields = []
 

InvenTree/static/script/inventree/modals.js

@@ -57,8 +57,9 @@ function modalSetContent(modal, content='') {
     $(modal).find('.modal-form-content').html(content);
 }
 
-function modalSetButtonText(modal, text) {
+function modalSetButtonText(modal, submit_text, close_text) {
-    $(modal).find("#modal-form-submit").html(text);
+    $(modal).find("#modal-form-submit").html(submit_text);
+    $(modal).find("#modal-form-close").html(close_text);
 }
 
 function closeModal(modal='#modal-form') {
@@ -102,9 +103,11 @@ function openModal(options) {
         modalSetContent(modal, options.content);
     }
 
-    if (options.submit_label) {
+    // Default labels for 'Submit' and 'Close' buttons in the form
-        modalSetButtonText(modal, options.submit_label);
+    var submit_text = options.submit_text || 'Submit';
-    }
+    var close_text = options.close_text || 'Close';
+
+    modalSetButtonText(modal, submit_text, close_text);
 
     $(modal).modal({
         backdrop: 'static',
@@ -243,23 +246,27 @@ function launchModalForm(url, options = {}) {
 
     var modal = options.modal || '#modal-form';
 
+    // Default labels for 'Submit' and 'Close' buttons in the form
+    var submit_text = options.submit_text || 'Submit';
+    var close_text = options.close_text || 'Close';
+
     // Form the ajax request to retrieve the django form data
     ajax_data = {
         url: url,
         type: 'get',
         dataType: 'json',
         beforeSend: function () {
-            openModal({modal: modal});
+            openModal({
+                modal: modal,
+                submit_text: submit_text,
+                close_text: close_text,
+            });
         },
         success: function(response) {
             if (response.title) {
                 modalSetTitle(modal, response.title);
             }
 
-            if (response.submit_label) {
-                modalSetButtonText(modal, String(response.submit_label));
-            }
-
             if (response.html_form) {
                 injectModalForm(modal, response.html_form);
                 handleModalForm(url, options);

InvenTree/static/script/inventree/stock.js

@@ -207,7 +207,7 @@ function moveStockItems(items, options) {
             openModal({
                 modal: modal,
                 title: "Move " + items.length + " stock items",
-                submit_label: "Move"
+                submit_text: "Move"
             });
 
             // Extact part row info

InvenTree/stock/templates/stock/item.html

@@ -135,7 +135,8 @@
         launchModalForm(
                         "{% url 'stock-item-edit' item.id %}",
                         {
-                            reload: true
+                            reload: true,
+                            submit_text: "Save",
                         });
     });
 
@@ -145,6 +146,7 @@
                         "{% url 'stock-item-move' item.id %}",
                         {
                             reload: true,
+                            submit_text: "Move"
                         });
         });
 

InvenTree/stock/views.py

@@ -134,7 +134,6 @@ class StockItemMove(AjaxUpdateView):
     template_name = 'modal_form.html'
     context_object_name = 'item'
     ajax_form_title = 'Move Stock Item'
-    ajax_submit_text = 'Move'
     form_class = MoveStockItemForm
 
     def post(self, request, *args, **kwargs):

InvenTree/templates/modals.html

@@ -10,7 +10,7 @@
             <div class='modal-form-content'>
             </div>
             <div class='modal-footer'>
-                <button type='button' class='btn btn-default' data-dismiss='modal'>Close</button>
+                <button type='button' class='btn btn-default' id='modal-form-close' data-dismiss='modal'>Close</button>
                 <button type='button' class='btn btn-primary' id='modal-form-submit'>Submit</button>
             </div>
         </div>