Mirrored_Repos/InvokeAI
1
0
Fork 0
mirror of https://github.com/invoke-ai/InvokeAI synced 2024-08-30 20:32:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(ui): add comment & TODO for konva bug

Browse Source
This commit is contained in:
psychedelicious 2024-05-09 14:12:39 +10:00 committed by Kent Keirsey
parent 2f9a064d48
commit 029ee90351
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
invokeai/frontend/web/src/features/controlLayers/util/renderers.ts
View File

@ -483,6 +483,9 @@ const updateInitialImageLayerImageAttrs = (
konvaImage: Konva.Image, konvaImage: Konva.Image,
reduxLayer: InitialImageLayer reduxLayer: InitialImageLayer
) => { ) => {
// Konva erroneously reports NaN for width and height when the stage is hidden. This causes errors when caching,
// but it doesn't seem to break anything.
// TODO(psyche): Investigate and report upstream.
const newWidth = stage.width() / stage.scaleX(); const newWidth = stage.width() / stage.scaleX();
const newHeight = stage.height() / stage.scaleY(); const newHeight = stage.height() / stage.scaleY();
if ( if (
@ -618,6 +621,9 @@ const updateControlNetLayerImageAttrs = (
reduxLayer: ControlAdapterLayer reduxLayer: ControlAdapterLayer
) => { ) => {
let needsCache = false; let needsCache = false;
// Konva erroneously reports NaN for width and height when the stage is hidden. This causes errors when caching,
// but it doesn't seem to break anything.
// TODO(psyche): Investigate and report upstream.
const newWidth = stage.width() / stage.scaleX(); const newWidth = stage.width() / stage.scaleX();
const newHeight = stage.height() / stage.scaleY(); const newHeight = stage.height() / stage.scaleY();
const hasFilter = konvaImage.filters() !== null && konvaImage.filters().length > 0; const hasFilter = konvaImage.filters() !== null && konvaImage.filters().length > 0;