feat(ui): use pubsub to for globalcontextmenuclose

Far more efficient than the crude redux incrementor thing.
This commit is contained in:
psychedelicious
2023-12-30 23:53:55 +11:00
committed by Kent Keirsey
parent bd92a31d15
commit 2ba505cce9
7 changed files with 37 additions and 32 deletions

View File

@ -2,6 +2,7 @@ import { useToken } from '@chakra-ui/react';
import { createMemoizedSelector } from 'app/store/createMemoizedSelector';
import { stateSelector } from 'app/store/store';
import { useAppDispatch, useAppSelector } from 'app/store/storeHooks';
import { useGlobalMenuCloseTrigger } from 'common/hooks/useGlobalMenuCloseTrigger';
import { useIsValidConnection } from 'features/nodes/hooks/useIsValidConnection';
import {
connectionEnded,
@ -22,7 +23,6 @@ import {
viewportChanged,
} from 'features/nodes/store/nodesSlice';
import { $flow } from 'features/nodes/store/reactFlowInstance';
import { bumpGlobalMenuCloseTrigger } from 'features/ui/store/uiSlice';
import type { CSSProperties, MouseEvent } from 'react';
import { memo, useCallback, useMemo, useRef } from 'react';
import { useHotkeys } from 'react-hotkeys-hook';
@ -157,9 +157,10 @@ export const Flow = memo(() => {
[dispatch]
);
const { onCloseGlobal } = useGlobalMenuCloseTrigger();
const handlePaneClick = useCallback(() => {
dispatch(bumpGlobalMenuCloseTrigger());
}, [dispatch]);
onCloseGlobal();
}, [onCloseGlobal]);
const onInit: OnInit = useCallback((flow) => {
$flow.set(flow);

View File

@ -4,6 +4,7 @@ import { createMemoizedSelector } from 'app/store/createMemoizedSelector';
import { stateSelector } from 'app/store/store';
import { useAppDispatch, useAppSelector } from 'app/store/storeHooks';
import NodeSelectionOverlay from 'common/components/NodeSelectionOverlay';
import { useGlobalMenuCloseTrigger } from 'common/hooks/useGlobalMenuCloseTrigger';
import { useMouseOverNode } from 'features/nodes/hooks/useMouseOverNode';
import { nodeExclusivelySelected } from 'features/nodes/store/nodesSlice';
import {
@ -11,7 +12,6 @@ import {
NODE_WIDTH,
} from 'features/nodes/types/constants';
import { zNodeStatus } from 'features/nodes/types/invocation';
import { bumpGlobalMenuCloseTrigger } from 'features/ui/store/uiSlice';
import type { MouseEvent, PropsWithChildren } from 'react';
import { memo, useCallback, useMemo } from 'react';
@ -48,15 +48,16 @@ const NodeWrapper = (props: NodeWrapperProps) => {
const dispatch = useAppDispatch();
const opacity = useAppSelector((state) => state.nodes.nodeOpacity);
const { onCloseGlobal } = useGlobalMenuCloseTrigger();
const handleClick = useCallback(
(e: MouseEvent<HTMLDivElement>) => {
if (!e.ctrlKey && !e.altKey && !e.metaKey && !e.shiftKey) {
dispatch(nodeExclusivelySelected(nodeId));
}
dispatch(bumpGlobalMenuCloseTrigger());
onCloseGlobal();
},
[dispatch, nodeId]
[dispatch, onCloseGlobal, nodeId]
);
return (