From 6cc629e19d525628879cec9663ccf3b8d2074aad Mon Sep 17 00:00:00 2001 From: Martin Kristiansen Date: Thu, 10 Aug 2023 23:32:31 -0400 Subject: [PATCH] Adding flake8 to GHA and pre-commit. Fixing missing flake8 --- .github/workflows/style-checks.yml | 8 ++++---- .pre-commit-config.yaml | 7 +++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/style-checks.yml b/.github/workflows/style-checks.yml index d29b489418..8a66d6490c 100644 --- a/.github/workflows/style-checks.yml +++ b/.github/workflows/style-checks.yml @@ -1,6 +1,6 @@ name: style checks -# just formatting for now -# TODO: add isort and flake8 later +# just formatting and flake8 for now +# TODO: add isort later on: pull_request: @@ -20,8 +20,8 @@ jobs: - name: Install dependencies with pip run: | - pip install black + pip install black flake8 # - run: isort --check-only . - run: black --check . - # - run: flake8 + - run: flake8 diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 2b16b274d6..9ef8b79e77 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -8,3 +8,10 @@ repos: language: system entry: black types: [python] + + - id: flake8 + name: flake8 + stages: [commit] + language: system + entry: flake8 + types: [python]