Mirrored_Repos/InvokeAI
1
0
Fork 0
mirror of https://github.com/invoke-ai/InvokeAI synced 2024-08-30 20:32:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): do not remove exposed fields when updating workflows

Browse Source
This commit is contained in:
psychedelicious 2024-05-19 15:11:51 +10:00
parent 0b5696c5d4
commit 9ed5698aa8
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
invokeai/frontend/web/src/features/nodes/store/workflowSlice.ts
View File

@ -142,13 +142,29 @@ export const workflowSlice = createSlice({
builder.addCase(nodeEditorReset, () => deepClone(initialWorkflowState)); builder.addCase(nodeEditorReset, () => deepClone(initialWorkflowState));
builder.addCase(nodesChanged, (state, action) => { builder.addCase(nodesChanged, (state, action) => {
// Not all changes to nodes should result in the workflow being marked touched // If a node was removed, we should remove any exposed fields that were associated with it. However, node changes
action.payload.forEach((change) => { // may remove and then add the same node back. For example, when updating a workflow, we replace old nodes with
if (change.type === 'remove') { // updated nodes. In this case, we should not remove the exposed fields. To handle this, we find the last remove
state.exposedFields = state.exposedFields.filter((f) => f.nodeId !== change.id); // and add changes for each exposed field. If the remove change comes after the add change, we remove the exposed
// field.
const exposedFieldsToRemove: FieldIdentifier[] = [];
state.exposedFields.forEach((field) => {
const removeIndex = action.payload.findLastIndex(
(change) => change.type === 'remove' && change.id === field.nodeId
);
const addIndex = action.payload.findLastIndex(
(change) => change.type === 'add' && change.item.id === field.nodeId
);
if (removeIndex > addIndex) {
exposedFieldsToRemove.push({ nodeId: field.nodeId, fieldName: field.fieldName });
} }
}); });
state.exposedFields = state.exposedFields.filter(
(field) => !exposedFieldsToRemove.some((f) => isEqual(f, field))
);
// Not all changes to nodes should result in the workflow being marked touched
const filteredChanges = action.payload.filter((change) => { const filteredChanges = action.payload.filter((change) => {
// We always want to mark the workflow as touched if a node is added, removed, or reset // We always want to mark the workflow as touched if a node is added, removed, or reset
if (['add', 'remove', 'reset'].includes(change.type)) { if (['add', 'remove', 'reset'].includes(change.type)) {
@ -165,7 +181,7 @@ export const workflowSlice = createSlice({
return false; return false;
}); });
if (filteredChanges.length > 0) { if (filteredChanges.length > 0 || exposedFieldsToRemove.length > 0) {
state.isTouched = true; state.isTouched = true;
} }
}); });