Resolves @bakkot's review

This commit is contained in:
psychedelicious 2022-10-06 12:55:34 +08:00 committed by Lincoln Stein
parent 97de5e31f9
commit c430f5452b
2 changed files with 10 additions and 22 deletions

View File

@ -3,7 +3,6 @@
# - Installs packages via yarn, using yarn.lock
# - Builds the frontend bundle
# - Commits the frontend bundle
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
name: Frontend CI/CD [dev]
@ -17,32 +16,27 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
defaults:
run:
working-directory: 'frontend'
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js 18
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: 18
cache: 'yarn'
cache-dependency-path: '**/yarn.lock' # THIS PATTERN did the trick for me.
cache-dependency-path: '**/yarn.lock'
- name: install packages
run: yarn install --immutable --immutable-cache --check-cache
- name: build frontend bundle [dev]
run: yarn build-dev
- name: setup git config
run: |
# setup the username and email. I tend to use 'GitHub Actions Bot' with no email by default
git config user.name "GitHub Actions Bot"
git config user.email "<>"
- name: commit bundle [dev]
run: |
git add dist/* -f
git commit -m "[bot] adds dev bundle"
git commit -m "[bot] builds dev bundle"
git push origin development

View File

@ -3,9 +3,8 @@
# - Installs packages via yarn, using yarn.lock
# - Builds the frontend bundle
# - Commits the frontend bundle
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
name: Frontend CI/CD [prod]
name: Frontend CI/CD [production]
on:
push:
@ -17,32 +16,27 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
defaults:
run:
working-directory: 'frontend'
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js 18
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: 18
cache: 'yarn'
cache-dependency-path: '**/yarn.lock' # THIS PATTERN did the trick for me.
cache-dependency-path: '**/yarn.lock'
- name: install packages
run: yarn install --immutable --immutable-cache --check-cache
- name: build frontend bundle [prod]
- name: build frontend bundle [production]
run: yarn build
- name: setup git config
run: |
# setup the username and email. I tend to use 'GitHub Actions Bot' with no email by default
git config user.name "GitHub Actions Bot"
git config user.email "<>"
- name: commit bundle [production]
run: |
git add dist/* -f
git commit -m "[bot] adds production bundle"
git commit -m "[bot] builds production bundle"
git push origin main