From d709c5519fd52afdb4d7abe74d3ce6c743bd0b5e Mon Sep 17 00:00:00 2001 From: psychedelicious <4822129+psychedelicious@users.noreply.github.com> Date: Tue, 20 Feb 2024 17:48:51 +1100 Subject: [PATCH] tidy(bulk_download): remove extraneous abstract methods `start`, `stop` and `__init__` are not required in implementations of an ABC or service. --- .../bulk_download/bulk_download_base.py | 23 +------------------ 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/invokeai/app/services/bulk_download/bulk_download_base.py b/invokeai/app/services/bulk_download/bulk_download_base.py index f085d384a9..617b611f56 100644 --- a/invokeai/app/services/bulk_download/bulk_download_base.py +++ b/invokeai/app/services/bulk_download/bulk_download_base.py @@ -1,26 +1,9 @@ from abc import ABC, abstractmethod from typing import Optional -from invokeai.app.services.invoker import Invoker - class BulkDownloadBase(ABC): - @abstractmethod - def start(self, invoker: Invoker) -> None: - """ - Starts the BulkDownloadService. - - This method is responsible for starting the BulkDownloadService and performing any necessary initialization - operations to prepare the service for use. - - param: invoker: The Invoker that holds all the services, required to be passed as a parameter to avoid circular dependencies. - """ - - @abstractmethod - def __init__(self): - """ - Create BulkDownloadBase object. - """ + """Responsible for creating a zip file containing the images specified by the given image names or board id.""" @abstractmethod def handler( @@ -52,10 +35,6 @@ class BulkDownloadBase(ABC): :return: The generated item ID. """ - @abstractmethod - def stop(self, *args, **kwargs) -> None: - """Stops the BulkDownloadService and cleans up.""" - @abstractmethod def delete(self, bulk_download_item_name: str) -> None: """