Commit Graph

24 Commits

Author SHA1 Message Date
psychedelicious
dd9b1c8eec feat(bulk_download): update response model, messages 2024-02-21 00:00:25 +11:00
psychedelicious
7f75f6226b tidy(bulk_download): don't store events service separately
Using the invoker object directly leaves no ambiguity as to what `_events_bus` actually is.
2024-02-20 23:39:30 +11:00
psychedelicious
6dc819fd47 tidy(bulk_download): do not rely on pagination API to get all images for board
We can get all images for the board as a list of image names, then pass that to `_image_handler` to get the DTOs, decoupling from the pagination API.
2024-02-20 23:39:30 +11:00
psychedelicious
0cc81e5d63 tidy(bulk_download): nit - use or as a coalescing operator
Just a bit cleaner.
2024-02-20 23:39:30 +11:00
psychedelicious
daecc54153 tidy(bulk_download): use single underscore for private attrs
Double underscores are used in the app but it doesn't actually do or convey anything that single underscores don't already do. Considered unpythonic except for actual dunder/magic methods.
2024-02-20 23:39:30 +11:00
psychedelicious
4c31c7f9f1 tidy(bulk_download): remove class-level attr annotations
These can be misleading as they shadow actual assigned class attributes. This pattern is in the rest of the app but it shouldn't be.
2024-02-20 23:39:30 +11:00
psychedelicious
d709c5519f tidy(bulk_download): remove extraneous abstract methods
`start`, `stop` and `__init__` are not required in implementations of an ABC or service.
2024-02-20 23:39:30 +11:00
psychedelicious
5d84ecef49 tidy(bulk_download): clean up comments 2024-02-20 23:39:30 +11:00
Stefan Tobler
641d246213 adding bulk_download_item_name to socket events 2024-02-20 23:39:30 +11:00
Stefan Tobler
2e53aa48c9 refactoring handlers to do null check 2024-02-20 23:39:30 +11:00
Stefan Tobler
ef12631450 removing dependency on an output folder, embrace python temp folder for bulk download 2024-02-20 23:39:30 +11:00
Stefan Tobler
8033589629 moving the responsibility of cleaning up board names to the service not the route 2024-02-20 23:39:30 +11:00
Stefan Tobler
0bde933c89 using temp directory for downloads 2024-02-20 23:39:30 +11:00
Stefan Tobler
fc5c5b6bdd returning the bulk_download_item_name on response for possible polling 2024-02-20 23:39:30 +11:00
Stefan Tobler
ff53563152 narrowing bulk_download stop service scope 2024-02-20 23:39:30 +11:00
Stefan Tobler
d06ee94fd3 cleaning up bulk download zip after the response is complete 2024-02-20 23:39:30 +11:00
Stefan Tobler
e99f3482cc refactoring bulk_download to be better managed 2024-02-20 23:39:30 +11:00
Stefan Tobler
888db8ac46 refactoring bulkdownload to consider image category 2024-02-20 23:39:30 +11:00
Stefan Tobler
7deef2cb27 fixing issue where default board did not return images 2024-02-20 23:39:30 +11:00
Stefan Tobler
ada807af0c using the board name to download boards 2024-02-20 23:39:30 +11:00
Stefan Tobler
aa132fb9e3 reworking some of the logic to use a default room, adding endpoint to download file on complete 2024-02-20 23:39:30 +11:00
Stefan Tobler
98a01368b8 linted and styling 2024-02-20 23:39:30 +11:00
Stefan Tobler
fc9a62dbf5 implementation of bulkdownload background task 2024-02-20 23:39:30 +11:00
Stefan Tobler
cf9dad83bc groundwork for the bulk_download_service 2024-02-20 23:39:30 +11:00