psychedelicious
98441ad08d
tidy(bulk_download): do not rely on pagination API to get all images for board
...
We can get all images for the board as a list of image names, then pass that to `_image_handler` to get the DTOs, decoupling from the pagination API.
2024-03-01 10:42:33 +11:00
psychedelicious
80c67dd6e0
tidy(bulk_download): nit - use or
as a coalescing operator
...
Just a bit cleaner.
2024-03-01 10:42:33 +11:00
psychedelicious
38af234108
tidy(bulk_download): use single underscore for private attrs
...
Double underscores are used in the app but it doesn't actually do or convey anything that single underscores don't already do. Considered unpythonic except for actual dunder/magic methods.
2024-03-01 10:42:33 +11:00
psychedelicious
2291122c2b
tidy(bulk_download): remove class-level attr annotations
...
These can be misleading as they shadow actual assigned class attributes. This pattern is in the rest of the app but it shouldn't be.
2024-03-01 10:42:33 +11:00
psychedelicious
bf3b10cb1c
tidy(bulk_download): remove extraneous abstract methods
...
`start`, `stop` and `__init__` are not required in implementations of an ABC or service.
2024-03-01 10:42:33 +11:00
psychedelicious
7f8f182a00
tidy(bulk_download): clean up comments
2024-03-01 10:42:33 +11:00
Stefan Tobler
e51867756a
adding bulk_download_item_name to socket events
2024-03-01 10:42:33 +11:00
Stefan Tobler
a8d7cf4e97
refactoring handlers to do null check
2024-03-01 10:42:33 +11:00
Stefan Tobler
037cac8154
removing dependency on an output folder, embrace python temp folder for bulk download
2024-03-01 10:42:33 +11:00
Stefan Tobler
b5a9ed351d
moving the responsibility of cleaning up board names to the service not the route
2024-03-01 10:42:33 +11:00
Stefan Tobler
f15aa562c2
using temp directory for downloads
2024-03-01 10:42:33 +11:00
Stefan Tobler
d0f3571e59
returning the bulk_download_item_name on response for possible polling
2024-03-01 10:42:33 +11:00
Stefan Tobler
b5ca1643a6
narrowing bulk_download stop service scope
2024-03-01 10:42:33 +11:00
Stefan Tobler
79eb871683
cleaning up bulk download zip after the response is complete
2024-03-01 10:42:33 +11:00
Stefan Tobler
7d91426d8f
refactoring bulk_download to be better managed
2024-03-01 10:42:33 +11:00
Stefan Tobler
795fbf0e81
refactoring bulkdownload to consider image category
2024-03-01 10:42:33 +11:00
Stefan Tobler
7114d64b86
fixing issue where default board did not return images
2024-03-01 10:42:33 +11:00
Stefan Tobler
c43ea9f25c
using the board name to download boards
2024-03-01 10:42:33 +11:00
Stefan Tobler
52b0deb179
reworking some of the logic to use a default room, adding endpoint to download file on complete
2024-03-01 10:42:33 +11:00
Stefan Tobler
7ecc18938b
linted and styling
2024-03-01 10:42:33 +11:00
Stefan Tobler
56d2d220a8
implementation of bulkdownload background task
2024-03-01 10:42:33 +11:00
Stefan Tobler
812e24cbd2
groundwork for the bulk_download_service
2024-03-01 10:42:33 +11:00