mirror of
https://github.com/invoke-ai/InvokeAI
synced 2024-08-30 20:32:17 +00:00
23c8a893e1
- Fixed a bug where after you load more, changing boards doesn't work. The offset and limit for the list image query had some wonky logic, now resolved. - Addressed major lag in gallery when selecting an image. Both issues were related to the useMultiselect and useGalleryImages hooks, which caused every image in the gallery to re-render on whenever the selection changed. There's no way to memoize away this - we need to know when the selection changes. This is a longstanding issue. The selection is only used in a callback, though - the onClick handler for an image to select it (or add it to the existing selection). We don't really need the reactivity for a callback, so we don't need to listen for changes to the selection. The logic to handle multiple selection is moved to a new `galleryImageClicked` listener, which does all the selection right when it is needed. The result is that gallery images no long need to do heavy re-renders on any selection change. Besides the multiselect click handler, there was also inefficient use of DND payloads. Previously, the `IMAGE_DTOS` type had a payload of image DTO objects. This was only used to drag gallery selection into a board. There is no need to hold onto image DTOs when we have the selection state already in redux. We were recalculating this payload for every image, on every tick. This payload is now just the board id (the only piece of information we need for this particular DND event). - I also removed some unused DND types while making this change. |
||
|---|---|---|
| .. | ||
| .storybook | ||
| config | ||
| docs | ||
| patches | ||
| public/locales | ||
| scripts | ||
| src | ||
| static/docs | ||
| tests | ||
| __init__.py | ||
| .eslintignore | ||
| .eslintrc.js | ||
| .gitignore | ||
| .prettierignore | ||
| .prettierrc.js | ||
| .unimportedrc.json | ||
| favicon-key.svg | ||
| favicon-outline.svg | ||
| index.html | ||
| package.json | ||
| pnpm-lock.yaml | ||
| tsconfig.json | ||
| tsconfig.node.json | ||
| vite.config.mts | ||
